Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close milestone database when calling Backend.close #242

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Close milestone database when calling Backend.close #242

merged 1 commit into from
Sep 5, 2018

Conversation

alecgibson
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 94.089% when pulling c1f58a5 on close-milestone-database into 0249c91 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 94.089% when pulling c1f58a5 on close-milestone-database into 0249c91 on master.

ericyhwang
ericyhwang approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@ericyhwang ericyhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the catch!

I'm going to wait to merge+publish this with your other two milestone-related sharedb PRs.

@ericyhwang ericyhwang self-assigned this Aug 29, 2018
@ericyhwang ericyhwang merged commit fb906ef into master Sep 5, 2018
@ericyhwang ericyhwang deleted the close-milestone-database branch September 5, 2018 20:37
@ericyhwang
Copy link
Contributor

Published as [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyhwang ericyhwang ericyhwang approved these changes

Assignees

@ericyhwang ericyhwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alecgibson @coveralls @ericyhwang