Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp methods #2

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Add timestamp methods #2

merged 2 commits into from
Feb 14, 2019

Conversation

alecgibson
Copy link
Collaborator

This change adds new milestone database methods for fetching
milestones by timestamp.

In order to make this performant, this change also adds a new index to
the m.mtime (modified timestamp) field.

This change adds [new milestone database methods][1] for fetching
milestones by timestamp.

In order to make this performant, this change also adds a new index to
the `m.mtime` (modified timestamp) field.

[1]: share/sharedb#262
@coveralls
Copy link

coveralls commented Jan 30, 2019

Pull Request Test Coverage Report for Build 31

  • 38 of 38 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 24: 0.0%
Covered Lines: 126
Relevant Lines: 126

💛 - Coveralls

Copy link

@nateps nateps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments about code clarity and tests mostly.

Thanks!

lib/mongo-milestone-db.js Outdated Show resolved Hide resolved
lib/mongo-milestone-db.js Show resolved Hide resolved
test/mongo-milestone-db.js Show resolved Hide resolved
This change refactors the `_getMilestoneSnapshotByTimestamp` method
according to code review comments.
@alecgibson alecgibson merged commit 5540874 into master Feb 14, 2019
@alecgibson alecgibson deleted the add-timestamp-methods branch February 14, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants