Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate large enough IP Address array for discovered devices #109

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

sharadb-amazon
Copy link
Owner

Change summary

  • Make the CommonResolutionData::kMaxIPAddresses in Resolver.h configurable so that different apps can choose to increase the allocated size of the array holding IP addresses of discovered devices.
  • This PR also fixes a bug on the MatterTvCastingBridge side, where the first IP Address from the CPP DiscoveredNodeData was being copied in all of the entries in the Objective-C array for IP Addresses.

Testing

Tested with the iOS tv-casting-app and the Linux tv-app

Copy link
Collaborator

@cliffamzn cliffamzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this change looks OK and might help us get unblocked, it seems weird for a TV to be advertising more than 5 IP Addresses - is this a bug on the TV side?

@sharadb-amazon
Copy link
Owner Author

While this change looks OK and might help us get unblocked, it seems weird for a TV to be advertising more than 5 IP Addresses - is this a bug on the TV side?

"The number of IPv6 addresses depends on home router settings. Android devices typically obtain 6 IPv4/IPv6 addresses 1. IPv4 through DHCP 2. IPv6 Local-link 3. IPv6 ULA via SLAAC 4. IPv6 temporary ULA via SLAAC 5. IPv6 global via SLAAC 6. IPv6 temporary global via SLAAC.
Please note if Thread Board Router is online in the future, they will assign more IPv6 ULA addresses to the connected wifi devices on the same wifi network."

@github-actions
Copy link

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>

sharadb-amazon pushed a commit that referenced this pull request Jan 6, 2025
…oject-chip#36628)

* [SL-UP] Remove two algo design for the wifi retry mechanism (#103)

* [SL-UP] Rename ot interval to transport interval (#108)

* [SL-UP] Delete unnecessary double abstraction for the wiseconnect power save functions (#109)

* [SL-UP] Update spi-multiplex header inclusion (#110)

* [SL-UP] Fix Builds after Wi-Fi interface refactor (#111)

* [SL-UP] Remove WF200 define duplication to avoid value conflicts at runtime (#126)

* fix spacing

* restyle

* Fix define name

* add missing function

* Fix wf200 ICD build

* Restyled by clang-format

* Add debug config

* Re added sem check

---------

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants