native: improve isolated crypto interfaces #366
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shapeshift/hdwallet/DrP6CQH99qzCKZB6arbx4oQtdeyK |
| @@ -215,10 +215,10 @@ export function MixinNativeBTCWallet<TBase extends core.Constructor<NativeHDWall | |||
| return true; | |||
| } | |||
|
|
|||
| buildInput(coin: core.Coin, input: core.BTCSignTxInputNative): InputData | null { | |||
| return this.needsMnemonic(!!this.#seed, () => { | |||
| async buildInput(coin: core.Coin, input: core.BTCSignTxInputNative): Promise<InputData | null> { | |||
There was a problem hiding this comment.
This is the core reason things weren't like this before -- because buildInput() was synchronous and technically part of the public interface. That had trickle-down effects that prevented util.getKeyPair() from being async and from there propagated out.
Now that I'm more comfortable that I have a full picture of the the overall library and its use cases, I'm confident that this method should be marked protected if it weren't for the fact that we're unable to do so because the mixin strategy we use is build on exporting class expressions, which doesn't support protected or private. Therefore, I don't think this counts as a modification to the public API, so we can change it without breaking things.
| export default { | ||
| async create(keyPair: BIP32.Node): Promise<SigningDelegate> { |
There was a problem hiding this comment.
This helps normalize the way that isolation adapters are used -- via await Isolation.Adapters.Binance.create() just like any other isolation adapter.
mrnerdhair
changed the title
mrnerdhair
force-pushed
the
improve-isolation-interface
branch
from
c22f436 to
418e9c1
Compare
mrnerdhair
force-pushed
the
improve-isolation-interface
branch
from
418e9c1 to
fb2d264
Compare
This updates the isolated crypto interfaces so that all methods (and fields) are async. The previous definition supported an async implementation, but would have required a complicated wrapper to ensure that a couple of operations "looked" synchronous. Eliminating that requirement comes primarily from having touched enough of the code to realize that
buildInput()can be made async safely.This also updates all the native wallet so that it can be initialized with an
Isolation.Core.Bip32.Nodeinstead of anIsolation.Core.Bip32.Mnemonic, which permits simpler isolation engine implementations, and renames theDummyengine toDefaultto better reflect its role and robustness.