Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some properties of SpiceDispenser MainActor #5

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Make some properties of SpiceDispenser MainActor #5

merged 1 commit into from
Jun 19, 2024

Conversation

Hans-shape
Copy link
Contributor

No description provided.

@Hans-shape Hans-shape requested a review from simonbs June 19, 2024 08:33
@Hans-shape
Copy link
Contributor Author

@simonbs The only breaking change is prepare(). As I can only imagine prepare() being called from the main actor (Either from UI, the ApplicationDelegate, or other lifecycle objects) I will make this a minor version, i.e. 2.1.0

@simonbs
Copy link
Contributor

simonbs commented Jun 19, 2024

@Hans-shape Sounds reasonable 👍

@Hans-shape Hans-shape merged commit d1d506a into master Jun 19, 2024
@simonbs simonbs deleted the fix/hans-shape/main_actor_spice_dispenser branch February 25, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbs simonbs simonbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hans-shape @simonbs