Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e697311c5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| required: [payload, execution_requests, builder_index, beacon_block_root, slot, state_root] | ||
| properties: | ||
| payload: | ||
| $ref: "../deneb/execution_payload.yaml#/Deneb/ExecutionPayload" |
There was a problem hiding this comment.
The updated publishBlockV2 description says that for Gloas and later, blobs are broadcast as part of the ExecutionPayloadEnvelope, but the envelope schema here no longer exposes any blob data or commitments (it only wraps a Deneb ExecutionPayload, which itself has no blob payload, plus execution requests). With blob_kzg_commitments removed from the envelope, clients following the new description have no defined place to submit blobs/commitments alongside the envelope, so they cannot actually fulfill the described behavior. Either the envelope needs a blob field again, or the block endpoint description should not claim blobs are carried via the envelope.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
in gloas there will be 2 different flows
- stateful: blobs are cached by the beacon node and broadcast when the execution payload is submitted
- stateless: blobs are passed around and submitted together with the execution payload and broadcast
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
2 participants
updates for v1.7.0-alpha.2