Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with OSS code #668

Closed
919Studios opened this issue Oct 5, 2018 · 51 comments
Closed

Not working with OSS code #668

919Studios opened this issue Oct 5, 2018 · 51 comments

Comments

@919Studios
Copy link

🐛 Describe the bug
"sync:download" does not install the extensions you specified when you ran "sync: upload/update".

🌴 Visual Studio Code Version : [ Version 1.27.2 (1.27.2) ]
🌴 Code Settings Sync Version : [ 3.1.2 ]
🌴 Operating System : [ MacOS Sierra 10.12.6 ]
🌴 Occurs On: [ Download ]
🌴 Proxy Enabled: [ NA ]
🌴 Gist Id: [ NA ]

📰 To Reproduce
Steps to reproduce the behavior:

  1. start by installing a few extensions that you wish to have synced when people use your gist.
  2. uploading will work and confirm that your extensions have been uploaded.
  3. although your Gist shows the extensions, running sync download will not install them.
  4. There is no error message, the extensions you are expecting to see installed simply just do not get installed.

💪 Expected behavior
The extensions we specified when we did the upload should be installed when we "sync: download" on a new machine.

📺 Console Error Log
No errors, "sync: download" will just ignore any setting you choose in an attempt to get it to download the extensions you have listed.

📺 Additional context
TO THE DEVELOPER- This Sync extension is really really great... if this "extension ignore bug" can be fixed this will really be a wonderful tool. Thank you for your help getting this solved.

@bergmul
Copy link

bergmul commented Oct 6, 2018

I can confirm this.

  • VSCode 1.27.2
  • Code Sync 3.1.2
  • OS: Antergos
  • Kernel: Linux 4.18.12-arch1-1-ARCH

@kucrut
Copy link

kucrut commented Oct 6, 2018

Came here to report this as well.

  • VSCode 1.27.2
  • Code Sync 3.1.2
  • OS Arch Linux
  • Kernel 4.18.12-arch1-1-ARCH

@tristan957
Copy link

I am confirming this on Solus. I am using the code-oss variant.

@andlpd
Copy link

andlpd commented Oct 7, 2018

Confirming this:

VSCode 1.27.2
Code Sync 3.1.2
OS Linux Mint
Kernel 4.15.0-36-generic

Console output confirm extensions being installed or being already installed, but extensions do not load in VSCode.

Maybe related to this:

  1. Locally installed extensions reside in: /home/$USER/.var/app/com.visualstudio.code/data/vscode/extensions
  2. Synced extensions reside under: /home/$USER/.vscode/extensions/

UPDATE:
I was able to solve the issue by uninstalling VSCode from the Software Manager and installing it from the .deb file with the Package Installer.

It seems that when installing through Software Manager the settings and extensions locations are different.

Hope this helps anyone else.

@sunriselink
Copy link

I have the same problem

vscode: 1.27.2 (user setup)
code sync: 3.1.2
os: Windows 10

@shanalikhan
Copy link
Owner

shanalikhan commented Oct 9, 2018

It seems that when installing through Software Manager the settings and extensions locations are different.

Guys try using Package Installer .deb file

If you are using portable VS Code, Settings Sync dont support it.

@timbioz
Copy link

timbioz commented Oct 10, 2018

Same to me.

  • VSCode-Insiders 1.27.2
  • Code Sync 3.1.2
  • OS: Win 10 Pro
  • Clean install for all - win, vscode, sync

@kamasylvia
Copy link

Same

  • VSCode: 1.27.2
  • Code Sync: 3.1.2
  • OS: Manjaro 17.1.12

Upload summary:

CODE SETTINGS SYNC UPLOAD SUMMARY
Version: 3.1.2
--------------------
GitHub Token: ***
GitHub Gist: ***
GitHub Gist Type: Secret

Restarting Visual Studio Code may be required to apply color and file icon theme.
--------------------
Files Uploaded:
  extensions.json > extensions.json
  bat.json > bat.json
  c.json > c.json
  cpp.json > cpp.json
  ftp-simple.json > ftp-simple.json
  keybindings.json > keybindings.json
  locale.json > locale.json
  material-icon-theme.json > material-icon-theme.json
  plaintext.json > plaintext.json
  python.json > python.json
  settings.json > settings.json
  csharp.json > snippets|csharp.json
  markdown.json > snippets|markdown.json
  vsicons.settings.json > vsicons.settings.json

Extensions Ignored:
  No extensions ignored.

Extensions Removed:
  No extensions removed.

Extensions Added:
  advanced-new-file v1.2.0
  amvim v1.30.0
  Angular2 v6.2.0
  angular2-switcher v0.1.9
  auto-rename-tag v0.0.15
  battery-indicator v1.0.0
  better-comments v2.0.2
  Bookmarks v9.1.0
  bootstrap4-vscode v4.3.0
  bracket-pair-colorizer v1.0.60
  code-settings-sync v3.1.2
  code-spell-checker v1.6.10
  comment v7.0.0
  csharp v1.16.2
  csharpextensions v1.3.0
  csharpfixformat v0.0.75
  dark-plus-material v1.4.3
  debugger-for-chrome v4.10.2
  docomment v0.1.2
  docthis v0.7.1
  dotnet-core-essentials v0.0.5
  dotnet-test-explorer v0.5.4
  eclipse-theme v0.0.9
  EditorConfig v0.12.4
  expand-region v0.1.2
  FlatUI v1.4.8
  flow-for-vscode v0.8.4
  ftp-sync v0.3.3
  gitlens v8.5.6
  Go v0.6.91
  html-css-class-completion v1.17.1
  html-tag-wrapper v0.2.3
  HTMLHint v0.5.0
  java v0.32.0
  JavaScriptSnippets v1.7.1
  Lisp v0.1.8
  MagicPython v1.1.0
  markdown-all-in-one v1.6.2
  markdown-checkbox v1.3.0
  markdown-preview-enhanced v0.3.8
  Material-theme v2.17.3
  mips v0.0.2
  mono-debug v0.15.8
  ng-template v0.1.10
  node-debug2 v1.28.3
  open-in-browser v2.0.0
  org-mode v0.5.0
  path-intellisense v1.4.2
  php-debug v1.12.6
  php-formatter v0.2.4
  plastic v2.2.0
  PowerShell v1.9.0
  prettier-vscode v1.6.1
  preview-vscode v1.4.4
  project-manager v9.0.1
  python v2018.9.0
  python v0.2.3
  quicktype v12.0.46
  rainglow v1.5.2
  rust v0.4.10
  spacemacs v1.1.1
  theme-dark-monokai v0.3.0
  theme-dracula v2.14.1
  theme-karyfoundation-themes v18.2.1
  theme-panda v1.3.0
  tslint v1.0.40
  typescript-javascript-grammar v0.0.45
  typings-installer v0.2.0
  vscode-angular2-files v1.6.2
  vscode-autohotkey v0.2.2
  vscode-clock v0.0.1
  vscode-color v0.4.5
  vscode-docker v0.3.1
  vscode-eslint v1.6.0
  vscode-firefox-debug v1.7.0
  vscode-great-icons v2.1.44
  vscode-html-css v0.2.0
  vscode-icons v7.27.0
  vscode-ipaddress v1.0.0
  vscode-java-debug v0.14.0
  vscode-language-pack-zh-hans v1.28.2
  vscode-markdownlint v0.20.0
  vscode-nuget-package-manager v1.1.6
  vscode-power-mode v2.2.0
  vscode-react-native v0.6.18
  vscode-rust v0.4.2
  vscode-table-formatter v1.2.1
  vscode-versionlens v0.21.2
--------------------
Done.

Download summary:

CODE SETTINGS SYNC DOWNLOAD SUMMARY
Version: 3.1.2
--------------------
GitHub Token: ***
GitHub Gist: ***
GitHub Gist Type: Secret

Restarting Visual Studio Code may be required to apply color and file icon theme.
--------------------
Files Downloaded:
 bat.json > bat.json
 c.json > c.json
 cpp.json > cpp.json
 extensions.json > extensions.json
 ftp-simple.json > ftp-simple.json
 keybindings.json > keybindings.json
 locale.json > locale.json
 material-icon-theme.json > material-icon-theme.json
 plaintext.json > plaintext.json
 python.json > python.json
 settings.json > settings.json
 snippets|csharp.json > snippets|csharp.json
 snippets|markdown.json > snippets|markdown.json
 vsicons.settings.json > vsicons.settings.json

Extensions Ignored:
 No extensions ignored.

Extensions Removed:
 No extensions removed.

Extensions Added:
 No extensions installed.
--------------------
Done.

@sunriselink
Copy link

sunriselink commented Oct 11, 2018

I have the same problem

vscode: 1.27.2 (user setup)
code sync: 3.1.2
os: Windows 10

This problem persists if the extension autoupdate is disabled.

@shanalikhan
Copy link
Owner

shanalikhan commented Oct 11, 2018

@ZhangYue-vhyt
are you using OSS or standard ?
can you show the image the developer console. Clearing the console and hit download and see what is written in developer console.

@TheSinding
Copy link

  • VSCode 1.27.2 OSS version
  • Code Sync 3.1.2
  • OS: Antergos
  • Kernel: Linux 4.18.12-arch1-1-ARCH

Same problem, it's because of the OSS version somehow.
I then changed to the closed source verison 1.28.0 and the settings sync is working.

@kirincc
Copy link

kirincc commented Oct 12, 2018

Visual Studio Code Version : [ Version 1.28.1 (system setup)]
🌴 Code Settings Sync Version : [ 3.1.2 ]
🌴 Operating System : [ windows10 1703[x64] ]
🌴 Occurs On: [ Download ]
🌴 Proxy Enabled: [ NA ]
🌴 Gist Id: [ NA ]

@Wykks
Copy link

Wykks commented Oct 13, 2018

Same issue with OSS version (the one bundled in Solus)

@shanalikhan
Copy link
Owner

Share the developer console log, v3.2 is going to publish in a week. I will try to add this in v3.2

@Wykks
Copy link

Wykks commented Oct 15, 2018

I only have this :

[Extension Host] Sync : Connected with user : 'Wykks' (at GitHubService.github.users.get.then.res (/home/[user]/.vscode/extensions/shan.code-settings-sync-3.1.2/out/src/service/githubService.js:76:25))

[Extension Host] /usr/share/vscode/code-oss (at Function.<anonymous> (/home/[user]/.vscode/extensions/shan.code-settings-sync-3.1.2/out/src/service/pluginService.js:214:21))

My code config is here /home/[user]/.config/Code (but it's a symbolic link to /home/[user]/.config/Code - OSS)
Extensions (as shown in console log) are here : /home/[user]/.vscode

@shanalikhan shanalikhan changed the title sync:download will not sync/install extensions Not working with OSS code Oct 15, 2018
@atomdmac
Copy link

I'm having the same issue:
Visual Studio Code Version : OSS [ Version 1.27.2 (1.27.2) ]
Code Settings Sync Version : [ 3.2.0 ]
Operating System : [ Manjaro Linux ]

@kamasylvia
Copy link

I'm having the same issue:
Visual Studio Code Version : OSS [ Version 1.27.2 (1.27.2) ]
Code Settings Sync Version : [ 3.2.0 ]
Operating System : [ Manjaro Linux ]

Update VSCode to 1.28 in AUR can solve this problem.

@shanalikhan
Copy link
Owner

Can you guys update using latest version of code and settings sync v3.2.2

@tristan957
Copy link

This is still broken on the latest version. Also is there a way for this extension to stop defaulting to .config/Code on the OSS version on Linux. I have to manually symlink the .config/Code - OSS folder so the extension doesn't crash

@pjmtdw
Copy link

pjmtdw commented Nov 30, 2018

I have same problem.
My environment is recent Arch Linux and using package community/code.
Settings Sync version is 3.2.2.
When executing > Sync: Download Settings, I get this error message on OUTPUT view.

"bin/code" --install-extension eamodio.gitlens
Error: Command failed: "bin/code" --install-extension eamodio.gitlens
/bin/sh: no such file or directory: bin/code

Digging around the code, I assumed that problem is here

Arch Linux's /usr/bin/code of community/code is a script something like
ELECTRON_RUN_AS_NODE=1 exec electron /usr/lib/code/out/cli.js /usr/lib/code/code.js "$@"
here's the source

And finally the process is running with something like
/usr/lib/electron/electron (with..lots..of..arguments)

Therefore I think you should not rely that process.argv0 ends with code.

In case of using aur/visual-studio-code-bin package, this problem won't occur since process is running with /opt/visual-studio-code/code, and also /opt/visual-studio-code/bin/code exists.

@kamasylvia
Copy link

I have same problem.
My environment is recent Arch Linux and using package community/code.
Settings Sync version is 3.2.2.
When executing > Sync: Download Settings, I get this error message on OUTPUT view.

"bin/code" --install-extension eamodio.gitlens
Error: Command failed: "bin/code" --install-extension eamodio.gitlens
/bin/sh: no such file or directory: bin/code

Digging around the code, I assumed that problem is here

Arch Linux's /usr/bin/code of community/code is a script something like
ELECTRON_RUN_AS_NODE=1 exec electron /usr/lib/code/out/cli.js /usr/lib/code/code.js "$@"
here's the source

And finally the process is running with something like
/usr/lib/electron/electron (with..lots..of..arguments)

Therefore I think you should not rely that process.argv0 ends with code.

In case of using aur/visual-studio-code-bin package, this problem won't occur since process is running with /opt/visual-studio-code/code, and also /opt/visual-studio-code/bin/code exists.

Don't use the package community/code.

@dan-dr
Copy link

dan-dr commented Dec 17, 2018

I found the cause, a workaround and PR'd.

The root cause seems to be that the extension tries to run the vscode cli but has the wrong path to it: https://github.com/shanalikhan/code-settings-sync/blob/b6c9f4c887/src/service/pluginService.ts#L312

I'm on Solus Linux, with VS Code from the Software Center, so my cli is in /usr/share/vscode/bin/code-oss while the extension tries to run /usr/share/vscode/bin/code. Creating a symlink between the two fixes the issue for me.

Note that I also symlinked /usr/bin/code-oss and /usr/bin/code, though I don't believe it's related (give it a go without).

@shanalikhan shanalikhan modified the milestones: Backlog, v3.3.0 Jun 6, 2019
shanalikhan pushed a commit that referenced this issue Jun 7, 2019
* fix(OSS):

enums.ts
----
Allow for setting os type with less code

environmentPath.ts
----
Find code folder and extensions folder more efficiently
Get OS type more efficiently

settings.ts
----
Ignore all state files

sync.ts
----
Adapt for changes in pluginService

pluginService.ts
----
Use vscode command to install extensions
Clean up code and simplify names

* Install extensions in order

* Comment legacy code instead of deleting it

* Fix extension install

* Fix issue with extensions always being deleted

* Get code path more efficiently

* Make sure to escape spaces in cli path

* Fix issues with portable builds

* Support Windows and certain editions

* Improve method for finding extension folder

* Start using API for installation

* Prepare for new API command

* Get ready for new API command

* Fix issue with installation

* Commit requested changes
shanalikhan added a commit that referenced this issue Jun 7, 2019
shanalikhan pushed a commit that referenced this issue Jun 11, 2019
* Throw error

* Try to fix issues with getting missing
shanalikhan pushed a commit that referenced this issue Jun 14, 2019
shanalikhan pushed a commit that referenced this issue Jun 14, 2019
shanalikhan pushed a commit that referenced this issue Jun 19, 2019
shanalikhan pushed a commit that referenced this issue Jun 24, 2019
* fix(OSS):

enums.ts
----
Allow for setting os type with less code

environmentPath.ts
----
Find code folder and extensions folder more efficiently
Get OS type more efficiently

settings.ts
----
Ignore all state files

sync.ts
----
Adapt for changes in pluginService

pluginService.ts
----
Use vscode command to install extensions
Clean up code and simplify names

* Install extensions in order

* Comment legacy code instead of deleting it

* Fix extension install

* Fix issue with extensions always being deleted

* Get code path more efficiently

* Make sure to escape spaces in cli path

* Fix issues with portable builds

* Support Windows and certain editions

* Improve method for finding extension folder

* Start using API for installation

* Prepare for new API command

* Get ready for new API command

* Fix issue with installation

* Commit requested changes
shanalikhan added a commit that referenced this issue Jun 24, 2019
shanalikhan pushed a commit that referenced this issue Jun 24, 2019
* Throw error

* Try to fix issues with getting missing
shanalikhan pushed a commit that referenced this issue Jun 24, 2019
shanalikhan pushed a commit that referenced this issue Jun 24, 2019
shanalikhan pushed a commit that referenced this issue Jun 24, 2019
@shanalikhan
Copy link
Owner

Settings Sync now officially supports OSS versions.

I have released new version of Settings Sync v3.3.0 fixing this issue. Im closing this ticket let me know if u guys run into some problem.

@shanalikhan shanalikhan unpinned this issue Jun 24, 2019
shanalikhan pushed a commit that referenced this issue Jul 1, 2019
* Updated to task api 2.0.0 and fixed tests

* Set "extensionKind": "ui" to support remote development #61

Fixes #870. See that issue for details

* Clean up previous commits into one

* #800 #515 #854

* Utilized pragmaUtil Functions for kb.json file

* Typo fix

* Added universalKeybindings setting

* chore(package): update @types/node to version 12.0.0 (#873)

* Cleaned up toggling commented settings (#877)

* Cleaned up toggling commented settings

* Updated to include fix by @ioprotium

* Fix warning with webpack

* Update UI

* Change height to max-height

* Add image locally and move it to the top

* Added documentation for tests in CONTRIBUTING.md (#881)

* fix(package): update fs-extra to version 8.0.0 (#882)

* chore(package): update @types/fs-extra to version 7.0.0 (#885)

* chore(package): update @types/node to version 12.0.1 (#883)

* fix(package): update fs-extra to version 8.0.1 (#884)

* Update UI to fit guidelines

* chore(package): update @types/node to version 12.0.2 (#887)

* Improve UI and functionality

* Match BG of theme and properly contrast text

* Fix issues with themes

* Fix image not showing up with light theme

* Fix issues with contrast

* Fix issue with VS Code's WebView

* Update UI and functionality

* Fix potential issue with light themes

* Fix issues with theme on modal

* Refactor

* Add new (but experimental) localizations (#898)

* chore(package): update clean-webpack-plugin to version 3.0.0 (#899)

*  #891

* Update settings page after a reset

* Improve code

* fix(clean-webpack-plugin): (#901)

clean-webpack-plugin was recently updated, and it had breaking changes.

* chore(package): update @types/node to version 12.0.3 (#897)

* #668

* fix(OSS):

enums.ts
----
Allow for setting os type with less code

environmentPath.ts
----
Find code folder and extensions folder more efficiently
Get OS type more efficiently

settings.ts
----
Ignore all state files

sync.ts
----
Adapt for changes in pluginService

pluginService.ts
----
Use vscode command to install extensions
Clean up code and simplify names

* Install extensions in order

* Comment legacy code instead of deleting it

* Fix extension install

* Fix issue with extensions always being deleted

* Get code path more efficiently

* Make sure to escape spaces in cli path

* Fix issues with portable builds

* Support Windows and certain editions

* Improve method for finding extension folder

* Start using API for installation

* Prepare for new API command

* Get ready for new API command

* Fix issue with installation

* Commit requested changes

* #668

* Format pluginService.ts (#906)

* #668

* Throw error

* Try to fix issues with getting missing

* chore(package): update @types/node to version 12.0.7 (#904)

* chore(package): update @types/node to version 12.0.8 (#908)

* #668

* #668

* #668

* #839

* Support multiple instances

* Completely switch to state

* Update to work properly

* Move setting classes to their own models

* Update service names

* Only auto upload using focused window

* Resolve merge conflicts

* #886

* Resolve locale properly

* Clean constructor

* Use state instead of passing in argument

* Update to be compatible with v3.3.0 changes

* Fix readme

* Fix package.json

* Add new settings

* Increase contrast

* Update

package.nls.*.json
----
Add localizations for setting names and placeholders.

github.oauth.service.ts
----
Handle errors in a more user-facing way
Support GitHub enterprise
Show message to user after success

webview.service.ts
----
Use new localizations for names and placeholders

* Bug fix and upload images

* Add support for commits to master (release notes)

* Fix issue

* Fix another issue with release notes

* Update release note template

* Update release notes

* Don't open gist selection if there aren't any gists

* Allow user to view gist

* Revert accidental change

* Support public gist

* Add css, js, and fonts to repo

* Improve font injection

* Revert accidental change
@rjayswal-pythonista
Copy link

Settings Sync now officially supports OSS versions.

I have released new version of Settings Sync v3.3.0 fixing this issue. Im closing this ticket let me know if u guys run into some problem.

I'm facing same issue with latest version of settings sync, wherein i'm unable to install extensions though some of the other settings are being synced.

Version: 1.50.1 (user setup)
Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a
Date: 2020-10-13T15:06:15.712Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.17134
Settings Sync: v3.4.3

@evanre
Copy link

evanre commented Oct 26, 2020

Hi @rjayswal-pythonista, I've faced with the same issue, but it turned out that code-setting-sync worked properly. The problem was that in my config were extensions that is absent in Marketplace that vscodium is bundled with.

@verajosemanuel
Copy link

same here. Arch Linux. Code OSS not syncing

"sync error. registered at console (menú help> Activate help > Toggle developer tools"

@tadsn3w
Copy link

tadsn3w commented May 23, 2021

Fedora not syncing either

unennhexium pushed a commit to unennhexium/vscodium that referenced this issue Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests