strip empty text nodes #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This screws up my layouts @yoshuawuyts Consider this: <em>Yes</em>
<span>yo</span>This should render as "Yes yo". With this change it becomes "Yesyo". You can replace multiple whitespace characters with a single blank though. That'd be fine. |
This was referenced May 10, 2017
|
Yeah, we also ran into this with Uppy: <div>
<strong>${this.i18n('chooseFile')}</strong> <span class="UppyDragDrop-dragText">${this.i18n('orDragDrop')}</span>
</div>Space between strong and span gets removed :( |
arturi
added a commit
to transloadit/uppy
that referenced
this pull request
May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so that random whitespace does not create empty text nodes
See Also