Update depending react-on-rails to ^10.0.0 #959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
I'd also like to know why the package depends on itself; I can't quite fathom why that would be useful 😸 |
shepmaster
reviewed
Oct 20, 2017
| dependencies: | ||
| react-on-rails "^9.0.3" | ||
| react-redux "^5.0.6" | ||
|
|
||
| react-on-rails@^9.0.0-beta.12: |
There was a problem hiding this comment.
Should this old version still be here?
tricknotes
force-pushed
the
depends-on-react-on-rails-10
branch
from
5360240 to
446946d
Compare
|
@tricknotes @shepmaster Thank for this one. However, @Judahmeek will be submitting a fix soon that has this. |
|
hi, @Judahmeek. |
|
I send a new PR to remove these dependencies #968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But I'm not sure why the dependency is required...
This change is