Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated client/package.json creates production builds using webpack by default #895

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

serodriguez68
Copy link
Contributor

@serodriguez68 serodriguez68 commented Jul 15, 2017

WORK DONE

  1. The package.json file created by the generator now creates minified javascript production builds by default. This was done by adding the -p flag to webpack on the build:production script.
  2. A test was added to verify that the build:production script includes the -p flag.

NOTES

  1. I deleted the previous PR and created a new one because I squashed and rebased to keep the project history clean.
  2. Sorry for the delay, it took me a while to wrap my head around the development setup and the codebase.

This change is Reviewable

@justin808
Copy link
Member

:lgtm:

Thanks @serodriguez68


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

justin808 added a commit to shakacode/react-webpack-rails-tutorial that referenced this pull request Jul 15, 2017
@justin808 justin808 merged commit e6edd4f into shakacode:master Jul 17, 2017
justin808 added a commit to shakacode/react-webpack-rails-tutorial that referenced this pull request Jul 17, 2017
ryanbelke pushed a commit to ryanbelke/rails-react-yourtime that referenced this pull request Jan 4, 2019
joseph0919 added a commit to joseph0919/React_Webpack_Rails_Tutorial that referenced this pull request May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants