-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix devBuild #877
fix devBuild #877
Conversation
@mjhenkes This looks great. I'll examine this tomorrow. What are the reproduction steps to see the issue? @Conturbo can you try this out? |
@justin808 Assuming a webpack config that looks something like this. Then build assets for production (NODE_ENV=production webpack --config webpack.config.js) and the console will log "Webpack dev build for Rails". @chenqingspring I'd recommend checking |
@mjhenkes It makes more sense :) |
Reviewed 1 of 1 files at r2. Comments from Reviewable |
@chenqingspring Please add a changelog.md entry and I'll merge this. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
|
Reviewed 1 of 1 files at r3. CHANGELOG.md, line 12 at r3 (raw file):
Comments from Reviewable |
@@ -8,6 +8,10 @@ Changes since last non-beta release. | |||
|
|||
*Please add entries here for your pull requests.* | |||
|
|||
## [8.0.4] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the bottom of the file for how you do the diff of 8.04 and 8.03, @chenqingspring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I didn't notice the references :(
but the build failed again..
Thanks @chenqingspring! |
This change is