Don't pretty format JSON in development #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temp fix given that a hash may contain active record objects and that crashed with the call to JSON.pretty_generate
|
This will be properly fixed by: #787 |
robwise
reviewed
Apr 2, 2017
| @@ -73,7 +73,7 @@ | |||
| "build:dev:server": "webpack -w --config webpack.server.rails.build.config.js", | |||
| "build:server": "webpack --config webpack.server.rails.build.config.js", | |||
| "hot-assets": "babel-node server-rails-hot.js", | |||
| "install-react-on-rails": "npm i --save 'file:../../..'" | |||
| "install-react-on-rails": "rm -rf node_modules/react-on-rails && npm i 'file:../../..'" | |||
There was a problem hiding this comment.
does rm -rf return truthy here?
justin808
force-pushed
the
temp-fix-serialization-development
branch
from
b1bc903 to
fb39bc2
Compare
|
Changes Unknown when pulling fb39bc2 on temp-fix-serialization-development into ** on master**. |
|
hmmmm. I guess it could be properly fixed by replacing
with
(and reverting this patch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp fix given that a hash may contain active record objects and that
crashed with the call to JSON.pretty_generate
This change is