Automatically generate i18n javascript files for react-intl when the serve starts up. #642

JasonYCHuang · 2016-12-10T21:31:31Z

This PR is for shakacode/react-webpack-rails-tutorial#340
We need i18n_dir & default_locale in ReactOnRails configuration.

This change is

coveralls · 2016-12-10T21:43:11Z

Coverage increased (+0.04%) to 82.792% when pulling 38e92e2 on JasonYCHuang:i18n into 6370447 on shakacode:master.

justin808 · 2016-12-11T01:29:46Z

we want this pr to include i18n.rake

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

justin808 · 2016-12-22T08:01:54Z

@JasonYCHuang How's this PR going?

JasonYCHuang · 2016-12-22T08:49:02Z

@justin808 I am occupied recently, and will finish this during Xmas or New year holidays.

coveralls · 2016-12-27T10:12:54Z

Coverage increased (+0.02%) to 99.316% when pulling c367290 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

coveralls · 2016-12-27T10:12:54Z

Coverage increased (+0.02%) to 99.316% when pulling c367290 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

coveralls · 2016-12-27T10:12:54Z

Coverage increased (+0.02%) to 99.316% when pulling c367290 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

justin808 · 2016-12-28T00:26:34Z

@JasonYCHuang Looks potentially super amazing! We need updates to the docs and a CHANGELOG.md, as well as tests that demonstrate and verify locals_to_js.rb.

This is really a huge addition to the project! 👏 🎉

Reviewed 2 of 5 files at r2.
Review status: 2 of 5 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

JasonYCHuang · 2016-12-28T08:59:02Z

No problem, will update it later.

Review status: 2 of 5 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

coveralls · 2016-12-31T13:10:42Z

Coverage increased (+0.02%) to 99.316% when pulling 95d8a08 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

coveralls · 2016-12-31T13:10:42Z

Coverage increased (+0.02%) to 99.316% when pulling 95d8a08 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

coveralls · 2016-12-31T13:20:01Z

Coverage increased (+0.02%) to 99.316% when pulling 95d8a08 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

coveralls · 2016-12-31T13:39:09Z

Coverage increased (+0.02%) to 99.316% when pulling 2870647 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

coveralls · 2016-12-31T13:39:09Z

Coverage increased (+0.02%) to 99.316% when pulling 2870647 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

coveralls · 2016-12-31T13:39:09Z

Coverage increased (+0.02%) to 99.316% when pulling 2870647 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

JasonYCHuang · 2016-12-31T13:39:37Z

Update Readme, changelog, and add test

Review status: 2 of 8 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

coveralls · 2016-12-31T13:50:33Z

Coverage increased (+0.02%) to 99.316% when pulling 2870647 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

coveralls · 2016-12-31T13:57:18Z

Coverage increased (+0.02%) to 99.316% when pulling 2870647 on JasonYCHuang:i18n into 13cff3f on shakacode:master.

coveralls · 2017-01-08T11:37:39Z

Coverage increased (+0.02%) to 99.321% when pulling 37d1a2a on JasonYCHuang:i18n into 8db37b1 on shakacode:master.

coveralls · 2017-01-08T11:37:39Z

Coverage increased (+0.02%) to 99.321% when pulling 37d1a2a on JasonYCHuang:i18n into 8db37b1 on shakacode:master.

coveralls · 2017-01-08T12:37:46Z

Coverage increased (+0.02%) to 99.32% when pulling 093a996 on JasonYCHuang:i18n into 8db37b1 on shakacode:master.

coveralls · 2017-01-08T12:37:46Z

Coverage increased (+0.02%) to 99.32% when pulling 093a996 on JasonYCHuang:i18n into 8db37b1 on shakacode:master.

coveralls · 2017-01-08T12:37:46Z

Coverage increased (+0.02%) to 99.32% when pulling 093a996 on JasonYCHuang:i18n into 8db37b1 on shakacode:master.

coveralls · 2017-01-08T12:54:35Z

Coverage increased (+0.02%) to 99.32% when pulling d08a057 on JasonYCHuang:i18n into 8db37b1 on shakacode:master.

JasonYCHuang · 2017-01-08T13:04:06Z

Review status: 7 of 11 files reviewed at latest revision, 9 unresolved discussions.

docs/basics/i18n.md, line 7 at r4 (raw file):

Previously, justin808 (Justin Gordon) wrote…

and intl

??

update description.

docs/basics/i18n.md, line 32 at r4 (raw file):

Previously, justin808 (Justin Gordon) wrote…

Could you only use the files that react-intl wants? and not use the Rails files?

Not sure I understand your questions.

react-intl wants locale files in json format, and I generate translations.js & default.js. Their sources are rails locale files.

I update the summary, and hope this will be more clear.

docs/basics/i18n.md, line 37 at r4 (raw file):

Previously, justin808 (Justin Gordon) wrote…

Where do these 2 files come from?

These 2 files are generated by lib/react_on_rails/locales_to_js.rb in this PR.

docs/basics/i18n.md, line 41 at r4 (raw file):

Previously, justin808 (Justin Gordon) wrote…

We could do a quick check to see if the generated file is older than any of the locale files.

Done.

lib/react_on_rails/locales_to_js.rb, line 71 at r4 (raw file):

Previously, justin808 (Justin Gordon) wrote…

do we need "set" in the method name?

Done.

lib/react_on_rails/locales_to_js.rb, line 74 at r4 (raw file):

Previously, justin808 (Justin Gordon) wrote…

do we need "set" in the method name?

Done.

.byebug_history, line 1 at r4 (raw file):

Previously, justin808 (Justin Gordon) wrote…

@JasonYCHuang Please remove this file.

Done.

Comments from Reviewable

justin808 · 2017-01-10T21:06:13Z

Please either merge or rebase to address the merge conflict.

justin808 · 2017-01-10T21:07:25Z

Reviewed 5 of 5 files at r5.
Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

README.md, line 175 at r4 (raw file):

### I18n

You can enable the i18n functionality with [react-intl](https://github.com/yahoo/react-intl). ReactOnRails also converts traditional Rails locale files, `*.yml`, to required javascript files, `translations.js` & `default.js`, automatically.

I think we should consider mentioning that we support an optional automatic conversion of Rails *.yml files.

docs/basics/i18n.md, line 32 at r5 (raw file):

automatically after you finished the following settings.

finished settings is probably not what you're trying to say.

maybe you mean "configured the following settings"

lib/react_on_rails/locales_to_js.rb, line 21 at r5 (raw file):

                                          .select { |f| File.exist?(f) }
      files = files.sort_by { |f| File.mtime(f) }
      files.last(2).map { |f| File.basename(f) }

are there a small enough number of files that the performance would never matter?

Here's how we do it for the test helper: https://github.com/shakacode/react_on_rails/blob/master/lib/react_on_rails/test_helper/webpack_assets_status_checker.rb#L28

I actually think that's probably not super efficient either.

Comments from Reviewable

justin808 · 2017-01-10T21:07:47Z

Just a few comments remaining.

coveralls · 2017-01-11T16:43:55Z

Coverage increased (+0.02%) to 99.321% when pulling 24a4d79 on JasonYCHuang:i18n into a97e209 on shakacode:master.

coveralls · 2017-01-11T16:43:55Z

Coverage increased (+0.02%) to 99.321% when pulling 24a4d79 on JasonYCHuang:i18n into a97e209 on shakacode:master.

JasonYCHuang · 2017-01-11T16:50:09Z

Review status: 6 of 11 files reviewed at latest revision, 3 unresolved discussions.

README.md, line 175 at r4 (raw file):

Previously, justin808 (Justin Gordon) wrote…

I think we should consider mentioning that we support an optional automatic conversion of Rails *.yml files.

Done.

docs/basics/i18n.md, line 32 at r5 (raw file):

Previously, justin808 (Justin Gordon) wrote…

automatically after you finished the following settings.

finished settings is probably not what you're trying to say.

maybe you mean "configured the following settings"

Done.

lib/react_on_rails/locales_to_js.rb, line 21 at r5 (raw file):

Previously, justin808 (Justin Gordon) wrote…

are there a small enough number of files that the performance would never matter?

Here's how we do it for the test helper: https://github.com/shakacode/react_on_rails/blob/master/lib/react_on_rails/test_helper/webpack_assets_status_checker.rb#L28

I actually think that's probably not super efficient either.

Try to improve this, and add test.

Comments from Reviewable

justin808 · 2017-01-12T07:46:00Z

Really super awesome!

See comments! so close!

Reviewed 5 of 5 files at r6.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

CHANGELOG.md, line 11 at r6 (raw file):

- Removed foreman as a dependency. [#678](https://github.com/shakacode/react_on_rails/pull/678) by [x2es](https://github.com/x2es).

### Changed

Added...

spec/react_on_rails/locales_to_js_spec.rb, line 46 at r6 (raw file):

      it "doesn't update files" do
        mt = File.mtime(translations_path)
        sleep 1

Let's avoid the sleep!

http://stackoverflow.com/questions/32300446/stubbing-time-now-with-rspec

Set the time to be one minute ago.

Comments from Reviewable

…serve starts up

coveralls · 2017-01-12T19:22:03Z

Coverage increased (+0.02%) to 99.321% when pulling c0b4715 on JasonYCHuang:i18n into a97e209 on shakacode:master.

JasonYCHuang · 2017-01-12T19:34:07Z

@justin808 Thank you for patient reviews.
Hope we can finish the PR this week. 😄

Review status: 9 of 11 files reviewed at latest revision, 2 unresolved discussions.

CHANGELOG.md, line 11 at r6 (raw file):

Previously, justin808 (Justin Gordon) wrote…

Added...

Done.

spec/react_on_rails/locales_to_js_spec.rb, line 46 at r6 (raw file):

Previously, justin808 (Justin Gordon) wrote…

Let's avoid the sleep!

http://stackoverflow.com/questions/32300446/stubbing-time-now-with-rspec

Set the time to be one minute ago.

Done.

Comments from Reviewable

justin808 · 2017-01-12T19:42:34Z

Awesome!

I'll ship later today.

Reviewed 2 of 2 files at r7.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

…serve starts up (#642)

… time. (#340) Demonstrates use of i18n (internationalization) with React on Rails. Docs: https://github.com/shakacode/react_on_rails/blob/master/docs/basics/i18n.md Relevant PRs from React on Rails: * shakacode/react_on_rails#642 * shakacode/react_on_rails#717

justin808 · 2017-03-05T00:42:34Z

lib/generators/react_on_rails/templates/base/base/config/initializers/react_on_rails.rb.tt

+  # I18N OPTIONS
+  ################################################################################
+  # Replace the following line to the location where you keep translation.js & default.js.
+  config.i18n_dir = Rails.root.join("client", "app", "libs", "i18n")


@JasonYCHuang We added this here, with an invalid directory, and later we abort deploying or testing when this directory does not exist.

… time. (#340) Demonstrates use of i18n (internationalization) with React on Rails. Docs: https://github.com/shakacode/react_on_rails/blob/master/docs/basics/i18n.md Relevant PRs from React on Rails: * shakacode/react_on_rails#642 * shakacode/react_on_rails#717

JasonYCHuang mentioned this pull request Dec 10, 2016

Add an i18n functionality to change language using a dropdown in real time. shakacode/react-webpack-rails-tutorial#340

Merged

JasonYCHuang force-pushed the i18n branch 3 times, most recently from fdff007 to c367290 Compare December 27, 2016 10:02

JasonYCHuang changed the title ~~add i18n_dir & default_locale to configuration~~ Automatically generate javascript files for react-intl when the serve starts up. Dec 31, 2016

JasonYCHuang changed the title ~~Automatically generate javascript files for react-intl when the serve starts up.~~ Automatically generate i18n javascript files for react-intl when the serve starts up. Dec 31, 2016

JasonYCHuang force-pushed the i18n branch 2 times, most recently from d2188f1 to 95d8a08 Compare December 31, 2016 13:08

JasonYCHuang force-pushed the i18n branch 4 times, most recently from ffacf2c to 2870647 Compare December 31, 2016 13:36

JasonYCHuang force-pushed the i18n branch from 37d1a2a to 093a996 Compare January 8, 2017 12:27

JasonYCHuang force-pushed the i18n branch from 093a996 to d08a057 Compare January 8, 2017 12:43

JasonYCHuang force-pushed the i18n branch 2 times, most recently from d277795 to 24a4d79 Compare January 11, 2017 16:33

Automatically generate i18n javascript files for react-intl when the …

c0b4715

…serve starts up

JasonYCHuang force-pushed the i18n branch from 24a4d79 to c0b4715 Compare January 12, 2017 19:09

justin808 merged commit 9f0f63b into shakacode:master Jan 12, 2017

justin808 pushed a commit that referenced this pull request Feb 11, 2017

Automatically generate i18n javascript files for react-intl when the …

0090f5e

…serve starts up (#642)

justin808 reviewed Mar 5, 2017

View reviewed changes

justin808 mentioned this pull request Dec 20, 2017

Support for Rails' i18n pluralization #1000

Closed

Automatically generate i18n javascript files for react-intl when the serve starts up. #642

Automatically generate i18n javascript files for react-intl when the serve starts up. #642

Conversation

JasonYCHuang commented Dec 10, 2016 • edited Loading

coveralls commented Dec 10, 2016

justin808 commented Dec 11, 2016

justin808 commented Dec 22, 2016

JasonYCHuang commented Dec 22, 2016

coveralls commented Dec 27, 2016 • edited Loading

coveralls commented Dec 27, 2016

coveralls commented Dec 27, 2016

justin808 commented Dec 28, 2016

JasonYCHuang commented Dec 28, 2016

coveralls commented Dec 31, 2016

coveralls commented Dec 31, 2016 • edited Loading

coveralls commented Dec 31, 2016 • edited Loading

coveralls commented Dec 31, 2016

coveralls commented Dec 31, 2016

coveralls commented Dec 31, 2016 • edited Loading

JasonYCHuang commented Dec 31, 2016

coveralls commented Dec 31, 2016 • edited Loading

coveralls commented Dec 31, 2016 • edited Loading

coveralls commented Jan 8, 2017

coveralls commented Jan 8, 2017

coveralls commented Jan 8, 2017

coveralls commented Jan 8, 2017

coveralls commented Jan 8, 2017 • edited Loading

coveralls commented Jan 8, 2017 • edited Loading

JasonYCHuang commented Jan 8, 2017

justin808 commented Jan 10, 2017

justin808 commented Jan 10, 2017

justin808 commented Jan 10, 2017

coveralls commented Jan 11, 2017

coveralls commented Jan 11, 2017 • edited Loading

JasonYCHuang commented Jan 11, 2017

justin808 commented Jan 12, 2017

coveralls commented Jan 12, 2017 • edited Loading

JasonYCHuang commented Jan 12, 2017

justin808 commented Jan 12, 2017

justin808 Mar 5, 2017

Choose a reason for hiding this comment

JasonYCHuang commented Dec 10, 2016 •

edited

Loading

coveralls commented Dec 27, 2016 •

edited

Loading

coveralls commented Dec 31, 2016 •

edited

Loading

coveralls commented Dec 31, 2016 •

edited

Loading

coveralls commented Dec 31, 2016 •

edited

Loading

coveralls commented Dec 31, 2016 •

edited

Loading

coveralls commented Dec 31, 2016 •

edited

Loading

coveralls commented Jan 8, 2017 •

edited

Loading

coveralls commented Jan 8, 2017 •

edited

Loading

coveralls commented Jan 11, 2017 •

edited

Loading

coveralls commented Jan 12, 2017 •

edited

Loading