-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello world revision #584
Hello world revision #584
Conversation
@robwise @jbhatab @Judahmeek I'd like to get your feedback on this one. I'm going to create a sample repo with a PR generated from the generator. |
@robwise @jbhatab @Judahmeek @nostophilia I created: shakacode/react_on_rails-test-new-redux-generation#1 Let's comment on the code there and here. |
@nostophilia
Overall, I think this looks great. Just needs a bit of cleanup! Thanks for your contributions. I'd like to get this merged in the next day or so. If you cannot get to it, please let me know. I'd prefer to have you make the changes so that your name is in the commit history with one big commit. |
@justin808 @robwise |
@nostophilia Please let me know when you're ready. Please confirm if you got all the requested changes and if linting passes using the linter 13.0.0.
|
@justin808 |
shakacode/react_on_rails-test-new-redux-generation#8 So close! Just need to fix the lint errors on what's generated. BE SURE to use the linters in this commit: shakacode/react_on_rails-test-new-redux-generation@ef1bde4 You can cherry-pick this! |
|
||
render() { | ||
return ( | ||
<div> | ||
<HelloWorldWidget name={this.state.name} updateName={e => this.updateName(e)} /> | ||
<HelloWorld name={this.state.name} updateName={this.updateName} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that there will be a few small changes related to file and component name in no-redux example as HelloWorldWidget.jsx is shared.
Also, there's a lint violation here. And I simplified it a little bit with the arrow function.
@nostophilia when will you push v6 to https://github.com/shakacode/react_on_rails-test-new-redux-generation/ ? I'd like to get this change into the next release coming maybe this weekend. |
AMAZING JOB! Great teamwork! Big improvement! I'm shipping this! Reviewed 18 of 19 files at r1, 3 of 3 files at r2. Comments from Reviewable |
Fix #579
Revise some part of the hello world example with Redux
This change is