Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to react 15 #379

Merged
merged 2 commits into from
Apr 8, 2016
Merged

Updating to react 15 #379

merged 2 commits into from
Apr 8, 2016

Conversation

brucek
Copy link
Contributor

@brucek brucek commented Apr 8, 2016

Fixes #378


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.411% when pulling ee824ab on brucek:react_15 into 5929b3a on shakacode:master.

@@ -71,11 +71,11 @@
<%- if options.redux? -%>
"mirror-creator": "1.1.0",
<%- end -%>
"react": "^0.14.8",
"react": "^15.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brucek We need to change the peer dependency of the npm module to support either 14 or 15.

@brucek
Copy link
Contributor Author

brucek commented Apr 8, 2016

I didn't look at what it would take to test against both versions, if you just meant the package.json.tt deps needed to support both I think this should do it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.411% when pulling 8ce8935 on brucek:react_15 into 5929b3a on shakacode:master.

@justin808 justin808 merged commit a352eb2 into shakacode:master Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants