Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Base Generator Helpful Message #279

Conversation

aaronvb
Copy link
Member

@aaronvb aaronvb commented Feb 16, 2016

  • Add info for hot reloading server npm cmd.
  • Remove duplicate code from redux generator
    helpful msg because base now prints the same msg.
  • Update tests to reflect changes.

rails generate react_on_rails:install

screen shot 2016-02-15 at 9 38 19 pm


#277

Review on Reviewable

@justin808
Copy link
Member

Hi @aaronvb Can you please update the CHANGELOG and I'll push a new release with this once CI passes. You can update to the next bugfix version 3.0.2.

- Add info for hot reloading server npm cmd.
- Remove duplicate code from redux generator
  helpful msg because base now prints the same msg.
- Update tests to reflect changes.
- Update CHANGELOG.
@aaronvb aaronvb force-pushed the add_npm_express_server_to_generator_message branch from ed698ad to a800ba8 Compare February 16, 2016 08:02
@aaronvb
Copy link
Member Author

aaronvb commented Feb 16, 2016

@justin808 Done!

@justin808
Copy link
Member

Great job! I'll merge and release as soon as CI finishes.

justin808 added a commit that referenced this pull request Feb 16, 2016
…tor_message

Update Base Generator Helpful Message
@justin808 justin808 merged commit 1b71714 into shakacode:master Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants