Fix Bootstrap Sass Append to Gemfile #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the gemfile does not have an empty line at the end, append_to_file will append ‘gem bootstrap-sass’ to the last line. - Added a line break to the beginning of ‘gem bootstrap-sass’ to ensure it’s on a new line.
| @@ -62,7 +62,7 @@ def strip_application_scss_of_incompatible_sprockets_statements | |||
| end | |||
|
|
|||
| def add_bootstrap_sprockets_to_gemfile | |||
| append_to_file("Gemfile", "gem 'bootstrap-sass'\n") | |||
| append_to_file("Gemfile", "\ngem 'bootstrap-sass'\n") | |||
There was a problem hiding this comment.
Following the same convention we used here: https://github.com/shakacode/react_on_rails/blob/master/lib/generators/react_on_rails/base_generator.rb#L137
justin808
added a commit
that referenced
this pull request
Feb 9, 2016
Fix Bootstrap Sass Append to Gemfile
|
Thanks @aaronvb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
If the gemfile does not have an empty line at the end, append_to_file will append ‘gem bootstrap-sass’ to the last line.