Change hide! to the implementation to support rails 3.2 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2016
| @@ -6,7 +6,7 @@ | |||
| module ReactOnRails | |||
| module Generators | |||
| class BaseGenerator < Rails::Generators::Base # rubocop:disable Metrics/ClassLength | |||
| hide! | |||
| Rails::Generators.hide_namespace self.namespace | |||
There was a problem hiding this comment.
Let's use parens for the method call.
Any doc link for this?
There was a problem hiding this comment.
Is this what you are looking for?
http://apidock.com/rails/Rails/Generators/hide_namespace/class
There was a problem hiding this comment.
|
@flynfish Please make the paren change, and I'll merge. |
|
@justin808 done |
justin808
added a commit
that referenced
this pull request
Jan 7, 2016
Change hide! to the implementation to support rails 3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the generators to work in rails 3.2 because the hide! method only exists in rails 4.