mention tutorial code in docs related to react-router integration #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| For a fleshed out integration of react_on_rails with react-router, check out [React Webpack Rails Tutorial Code](https://github.com/shakacode/react-webpack-rails-tutorial), specifically the files: | ||
|
|
||
| [routes](https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/app/bundles/comments/routes/routes.jsx) |
There was a problem hiding this comment.
let's use the full path /client/something for these
and let's use bullets for formatting
…rences, add bullet styling
|
@justin808 added the full path to the file references and bullet formatting. Let me know if anything else should be adjusted... |
|
LGTM! Thanks! |
justin808
added a commit
that referenced
this pull request
Dec 16, 2015
mention tutorial code in docs related to react-router integration
|
no problem! thanks for pointing me to the tutorial! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some trouble getting react-router to work, though after @justin808 pointed me to the tutorial code I was able to figure it out. Think it might be useful for others to see a mention of the tutorial code in the react-router docs.