-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more detailed description when adding --help option to generator. #161
Conversation
@yorzi How do you feel about keeping the width to 80 chars? |
Change this to:
cc @justin808 |
@robwise will be the rewording master! |
The single character options are off by default. Thus, if you specify -R, you will add Redux. |
|
||
The react_on_rails:install generator combined with the example pull requests of generator runs | ||
will get you up and running efficiently. There's a fair bit of setup with integrating Webpack | ||
with Rails. Defaults for options are such that the default is for the flag to be off. For example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yorzi this sounds fine
@justin808 80 chars sounds good. let me update it. |
@robwise please help to review wordings in this PR. Thanks. |
|
||
The react_on_rails:install generator combined with the example pull requests of | ||
generator runs will get you up and running efficiently. There's a fair bit of | ||
setup with integrating Webpack with Rails. Defaults for options are such that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"setup involved when with integrating"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Defaults for options are such that the default is for the flag to be off."
@justin808 I still think the defaults thing is self-explanatory from running the rake descriptions. I'd at least change this sentence as it's super confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justin808 Also, a lot of this information, both the generators and linters information, is completely redundant and is already inside of the Readme. We should not have documentation for the same exact thing twice. The last thing we need to do is add more stuff to read. Let's either use the README version or this version, but not both? Then we delete what's in the README so that we only have to update this info in a single place from now on.
@yorzi @justin808 I added a bunch of editing-related comments. Sorry Andy, I know a lot of these are about things that weren't your fault but were already in the Readme like that because Justin or I wrote them that way! On that note, I think we should maintain a single source of truth and try to write our documentation in a way that minimizes the need for future updating whenever possible. Misinformation is worse than no information. Therefore, I think what we should do is change the sections in the Readme that are covered here to simply point to this file and delete the text in the README. Otherwise it's just too likely that we will forget to update one of the two. Lastly, Andy, have you double checked that this stuff actually shows up when you run the help command? Is it just automatically included if you called the file |
@robwise I will follow up your comments later. Thanks. And, YES, it just shows up when I run generator with a So, to define source_root and add one USAGE file in correct path are the tricks. |
@yorzi cool, I didn't know that!! |
Hi @yorzi and @robwise! I trust Rob's edits. Rob, it might be easier for you to apply many of the changes. In terms of avoiding duplication, there's no easy way around this. For example, suppose our README refers to the help output, but then one has to install the gem. If the help refers to the README, that's a bit better. Also, the README can have formatting, the output doesn't. One thing we could do is to save the --help output to a file and have the README refer to that. |
@justin808 The help output is saved to a file in a way— |
@justin808 We never got a final decision on my comment |
@yorzi Did you get a chance to make that change? Let's get this merged. |
@justin808 @robwise sorry for the delay, I've update the wording that Rob points out. |
…ator add more detailed description when adding --help option to generator.
Refers to: #159
Result as below: