Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for retrieving any option from render_options or nil instead #1213

Merged
merged 3 commits into from
May 6, 2019

Conversation

ashgaliyev
Copy link
Contributor

@ashgaliyev ashgaliyev commented May 2, 2019

This change is Reviewable

@ashgaliyev ashgaliyev force-pushed the andrey/add-option-method branch from f2b65ca to 620355b Compare May 2, 2019 15:46
@coveralls
Copy link

coveralls commented May 2, 2019

Coverage Status

Coverage remained the same at ?% when pulling 7a26701 on andrey/add-option-method into 3d772ea on master.

Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes requested.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashgaliyev)


CHANGELOG.md, line 17 at r1 (raw file):

Changes since last non-beta release.

- Added method for retrieving any option from `render_options` [PR 1213](https://github.com/shakacode/react_on_rails/pull/1213)
  • add by name
  • put in 11.3.0 and update date for it 😄

lib/react_on_rails/react_component/render_options.rb, line 75 at r1 (raw file):

      end

      def option(key)
def internal_option(key)
  options[key]
end

Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashgaliyev)

@justin808 justin808 merged commit 5a978a8 into master May 6, 2019
@justin808 justin808 deleted the andrey/add-option-method branch April 29, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants