Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract generation of js_code into module #1169

Merged
merged 2 commits into from
Dec 6, 2018
Merged

Conversation

ashgaliyev
Copy link
Contributor

@ashgaliyev ashgaliyev commented Nov 21, 2018

This change is Reviewable

@ashgaliyev ashgaliyev force-pushed the andrey/add-js-pro branch 2 times, most recently from bf05d78 to c5668a8 Compare November 21, 2018 08:54
@coveralls
Copy link

coveralls commented Nov 21, 2018

Coverage Status

Coverage remained the same at ?% when pulling 7a4207a on andrey/add-js-pro into 735c434 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling c5668a8 on andrey/add-js-pro into b4d3763 on master.

Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashgaliyev)


lib/react_on_rails/helper.rb, line 441 at r1 (raw file):

        initialize_redux_stores,
        react_component_name,
        render_options
         props_string: props_string(props).gsub("\u2028", '\u2028').gsub("\u2029", '\u2029'),
         rails_context: rails_context(server_side: true).to_json,
         redux_stores: initialize_redux_stores,
         react_component_name: react_component_name,
        render_options: render_options

lib/react_on_rails/server_rendering_js_code.rb, line 14 at r1 (raw file):

      end

      def server_rendering_component_js_code(
      def server_rendering_component_js_code(
         props_string: nil,
        rails_context: nil,
         redux_stores: nil,
         react_component_name: nil,
         render_options: nil
       )

@justin808 justin808 merged commit aa7060f into master Dec 6, 2018
@justin808 justin808 deleted the andrey/add-js-pro branch December 6, 2018 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants