Fix render during interactive readyState #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexeyMohnatkin Can you please review this? This change would revert part of your change for #1099. @rakelley Thanks for submitting this. Once this passes CI and so long as @alexeyMohnatkin does not have any objection, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by PR 1099, explained in issue 1150. The potential for this issue was raised during review of PR 1099 but not reproduced at that time, and is currently only reproducible for us in Chrome when utilizing
defered scripts which are preloaded.The code was cloned from jQuery
$.ready(), with the offending part of the condition existing to support IE versions < 9. This PR introduces a backwards-compatibility-break for those versions of IE, but should have no impact on any non-EOL browsers other than resolving this bug.This change is