Add support for webpacker 4 prereleases #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, Gem::Specification.find_by_name("webpacker") doesn't identify Webpacker 4 prereleases like webpacker 4.0.0.pre.pre.2 while Gem::Specification.find_all_by_name("webpacker") does. I've tested Gem::Specification.find_all_by_name for possible undesired side-effects, like returning multiple results for Gem::Specification.find_all_by_name("react"), and it has worked as desired in all cases that I've tested it.
|
LGTM. Thanks @Judahmeek. |
|
Let me know if you need me to cut a release. And please add an entry to the changelog.md on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, Gem::Specification.find_by_name("webpacker") doesn't identify Webpacker 4 prereleases like webpacker 4.0.0.pre.pre.2 while Gem::Specification.find_all_by_name("webpacker") does. I've tested Gem::Specification.find_all_by_name for possible undesired side-effects, like returning multiple results for Gem::Specification.find_all_by_name("react"), and it has worked as desired in all cases that I've tested it.
This change is