Use data attrs when rendering react_components instead of script tags #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client side rendering scripts do not get called when using the forward/back buttons with turbolinks, because turbolinks does not re-evaluate script tags when navigating through the history. Instead of creating script tags throughout the page, instead use html elements with data attributes specifying each react component to be rendered, and iterate through all of those elements whenever the page loads. This has the added benefit of removing global data variables from being set on the window object and simplifying the rendering code. (Note that it will be possible to support turbolinks navigation with the still-on-master `data-turbolinks-eval=always` feature of turbolinks. But this solution doesn't depend on that upgrade and is a bit cleaner anyway.)
Because that is to prevent XSS when JS is put in HTML.
* Avoid any chance of conflicts with a user desired class name. * Set display:none on the div with data for the react component. This should prevent the browser from having any rendering issues from the extra div.
justin808
force-pushed
the
ryanaip-data-tags
branch
from
a99dcb4 to
68246ea
Compare
|
@ryanaip @alexfedoseev I'm going to go with Ryan's changes for now. There's too many concerns with the next version of TurboLinks to depend on TurboLinks eval'ing the script tag. I tested out the Rails 5 version and it's not there right now, and v3 will probably never be released. |
justin808
changed the title
justin808
added a commit
that referenced
this pull request
Nov 22, 2015
Use data attrs when rendering react_components instead of script tags
This was referenced Nov 22, 2015
|
@ryanaip Big thanks for this fix. |
|
Looks good — Glad to help out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion at #102.