Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add random dom id option #1121

Merged
merged 3 commits into from
Jul 23, 2018
Merged

Add random dom id option #1121

merged 3 commits into from
Jul 23, 2018

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Jul 23, 2018 •
edited
Loading

This change is Reviewable

justin808 added 2 commits July 22, 2018 17:16
@justin808
Added configuration option random_dom_id
6d38d20 
This new global and react_component helper option allows configuring
whether or not React on Rails will automatically add a random id to the
DOM node ID.
@justin808
Added method RenderOptions has_random_dom_id?
ebef895
@justin808 justin808 force-pushed the add-random-dom-id-option branch from bc3e25f to ebef895 Compare July 23, 2018 03:35
@coveralls
Copy link

coveralls commented Jul 23, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at ?% when pulling 2ad5611 on add-random-dom-id-option into 15ba752 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling ebef895 on add-random-dom-id-option into 15ba752 on master.

@justin808 justin808 merged commit 82efd0b into master Jul 23, 2018
@justin808 justin808 mentioned this pull request Jul 23, 2018
Closed
@justin808 justin808 deleted the add-random-dom-id-option branch August 1, 2018 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin808 @coveralls