Fix component hash script #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justisb
force-pushed
the
component-hash-fix
branch
from
bb99dd5 to
583e502
Compare
|
@jblasco3 Thanks! I'm releasing 11.0.3 right now. |
Since this "common rendering" code is used in 2 places, I'm not sure that's necessary. However, I'd like to add a test that fails without this change. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
react_component_hash['componentHtml']does not include thejs-react-on-rails-componentscript tag that initializes React on Rails client-side, due to an invalid string key where a symbol is expected when building the tag internally.While this specific issue is now fixed in the PR, perhaps some of the hash results could be refactored to use
.fetchwhere a key should always be expected?This change is