Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install generator fails in environment without Git #888

Closed
jasonblalock opened this issue Jul 5, 2017 · 0 comments
Closed

Install generator fails in environment without Git #888

jasonblalock opened this issue Jul 5, 2017 · 0 comments
Labels
bug

Comments

@jasonblalock
Copy link
Contributor

When running the install generator in an environment without Git, it will fail to run citing:

react_on_rails-8.0.3/lib/react_on_rails/git_utils.rb:8:in `uncommitted_changes?': undefined method `empty?' for nil:NilClass (NoMethodError)

It will still fail when using --ignore-warnings because it tries to evaluate what git status is coming back before looking at the ignore flag. I ran into this specifically because I use docker and exclude the .git folders from my containers.
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommited_changes? to handle missing git
94627bc 
- Fix for GitUtils.uncommited_changes? throwing an error when called in
  an environment that does not have git installed causing install
  generator to fail
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommited_changes? to handle missing git
89437e5 
- Fix for GitUtils.uncommited_changes? throwing an error when called in
  an environment that does not have git installed
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing git
4828154 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing git
9231e65 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing git
f7005b8 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing Git
1dbcf7b 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing Git
43ac002 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
@jasonblalock jasonblalock mentioned this issue Jul 5, 2017
Merged
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing Git
62f6975 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing Git
e493c8a 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing Git
f1cea95 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing Git
f479898 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing Git
46f5c5c 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing Git
c87d783 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
jasonblalock added a commit to jasonblalock/react_on_rails that referenced this issue Jul 5, 2017
@jasonblalock
Update #uncommitted_changes? to handle missing Git
b0bb4ef 
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes shakacode#888
@justin808 justin808 added the bug label Jul 6, 2017
justin808 pushed a commit that referenced this issue Jul 17, 2017
@jasonblalock @justin808
Update #uncommitted_changes? to handle missing Git (#889)
41e4c06 
* Update #uncommitted_changes? to handle missing Git
- Fix for GitUtils.uncommitted_changes? throwing an error when called in
  an environment that does not have git installed
- Add tests for GitUtils.uncommitted_changes? scenariors
- Fixes #888
* Add explicit message when Git is not installed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justin808 @jasonblalock