Skip to content

Commit

Permalink
Improve generator post-install help messages (#631)
Browse files Browse the repository at this point in the history
* Improve generator post-install help messages
  • Loading branch information
justin808 authored Dec 1, 2016
1 parent 7ca22d3 commit d725e67
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ Contributors: please follow the recommendations outlined at [keepachangelog.com]

## [Unreleased]

## [6.3.1]
##### Changed
- Improved generator post-install help messages. [#631](https://github.com/shakacode/react_on_rails/pull/631) by [justin808](https://github.com/justin808).

## [6.3.0]
##### Changed
- Modified register API to allow registration of renderers, allowing a user to manually render their app to the DOM. This allows for code splitting and deferred loading. [#581](https://github.com/shakacode/react_on_rails/pull/581) by [jtibbertsma](https://github.com/jtibbertsma).
Expand Down Expand Up @@ -393,7 +397,8 @@ Best done with Object destructing:
##### Fixed
- Fix several generator related issues.

[Unreleased]: https://github.com/shakacode/react_on_rails/compare/6.3.0...master
[Unreleased]: https://github.com/shakacode/react_on_rails/compare/6.3.1...master
[6.3.1]: https://github.com/shakacode/react_on_rails/compare/6.3.0...6.3.1
[6.3.0]: https://github.com/shakacode/react_on_rails/compare/6.2.1...6.3.0
[6.2.1]: https://github.com/shakacode/react_on_rails/compare/6.2.0...6.2.1
[6.2.0]: https://github.com/shakacode/react_on_rails/compare/6.1.2...6.2.0
Expand Down
10 changes: 6 additions & 4 deletions lib/generators/react_on_rails/base_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,10 @@ def append_to_spec_rails_helper
else
GeneratorMessages.add_info(
<<-MSG.strip_heredoc
Did not find spec/rails_helper.rb or spec/spec_helper.rb to add line
config.example_status_persistence_file_path = "spec/examples.txt"
Did not find spec/rails_helper.rb or spec/spec_helper.rb to add
# Ensure that if we are running js tests, we are using latest webpack assets
# This will use the defaults of :js and :server_rendering meta tags
ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)
MSG
)
end
Expand All @@ -141,9 +143,9 @@ def print_helpful_message
bundle && npm i
- Run the npm rails-server command to load the rails server.
- Run the foreman command to start the rails server and run webpack in watch mode.
npm run rails-server
foreman start -f Procfile.dev
- Visit http://localhost:3000/hello_world and see your React On Rails app running!
MSG
Expand Down

0 comments on commit d725e67

Please sign in to comment.