moved throw from handleError to clientStartup

shakacode · Aug 18, 2016 · 84824b1 · 84824b1
1 parent 048c8d8
commit 84824b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/node_package/src/clientStartup.js b/node_package/src/clientStartup.js
@@ -78,11 +78,8 @@ You should return a React.Component always for the client side entry point.`);
       }
     }
   } catch (e) {
-    handleError({
-      e,
-      name,
-      serverSide: false,
-    });
+    e.message = `Exception in rendering ${name}. ${e.message}`;
+    throw e;
   }
 }
 

diff --git a/node_package/src/handleError.js b/node_package/src/handleError.js
@@ -53,19 +53,14 @@ export default (options) => {
   console.error(`message: ${e.message}`);
   console.error(`stack: ${e.stack}`);
 
-  msg += `Exception in rendering!
+  if (serverSide) {
+    msg += `Exception in rendering!
 ${e.fileName ? `\nlocation: ${e.fileName}:${e.lineNumber}` : ''}
 Message: ${e.message}
 
 ${e.stack}`;
 
-  if (serverSide) {
     const reactElement = React.createElement('pre', null, msg);
     return ReactDOMServer.renderToString(reactElement);
-  } else {
-    var newError = new Error(msg);
-
-    newError.cause = e;
-    throw newError;
   }
 };