Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redux to redux-server-rendering #127

Closed

Conversation

robwise
Copy link
Contributor

@robwise robwise commented Nov 29, 2015

No description provided.

@@ -4,7 +4,7 @@ gem 'react_on_rails', path: '../react_on_rails'


# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '4.2.4'
gem 'rails', '4.2.5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robwise Let's get rid of this diff noise the next time we regenerate. We'll update the the branch https://github.com/shakacode/react_on_rails-generator-results/tree/fresh-rails-install first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 that's the weird thing—this is a diff between redux and redux-server-rendering, so it's nothing to do with the differences from the fresh-rails-install, right?

@robwise robwise closed this Dec 6, 2015
@robwise robwise deleted the redux-to-redux-server-rendering-comparison-1_1_1 branch February 25, 2017 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants