Fix eslint plugin error #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged on #166. |
| const { $$commentsState } = initalStates; | ||
| const initialState = { | ||
| $$commentsStore: $$commentsState.merge({ | ||
| $$comments: initialComments, | ||
| $$comments: props, |
There was a problem hiding this comment.
This is bizarre.
- Please back out this change. The old code is important for readability.
- we should ignore the eslint rule here and with a comment to the github issue indicating the problem.
- please put a link to this code in the eslint issue (actually react-plugin probably, not main eslint)
Thanks @josiasds
There was a problem hiding this comment.
@josiasds @justin808 Maybe you can just disable the rule for only this file or block? and not for the whole app. Don't know if the plugin will allow this?
There was a problem hiding this comment.
@dylangrafmyre yep, we just need to put /* eslint react/prop-types: 0 */ at the top of the file or wrapping the whole block, see bc07695.
|
@josiasds @dylangrafmyre This needs to be reverted. See prior comments. Thanks. |
|
Previous change reverted and eslint rule disabled on commit bc07695. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some debugging and find out the line that was failing the linter, so I just rewrote it.