-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding extract text plugin as a peer dependency #109
Adding extract text plugin as a peer dependency #109
Conversation
- set extract-text-webpack-plugin as a peerDependencies on version 1.0.1 or lower - update the main documentation (./README.md) - update the basic example to use the latest supported version - stop git from tracking webstorm text editor settings
Reviewed 4 of 4 files at r1. .gitignore, line 5 [r1] (raw file):
remove package.json, line 38 [r1] (raw file):
Not sure if you want to be so precise. What if 1.0.2 is released? How about "< 2" (not sure a single digit works).
README.md, line 157 [r1] (raw file):
see comment regarding the peer specification examples/basic/package.json, line 53 [r1] (raw file):
not sure on the Comments from Reviewable |
- removing .idea from gitignore - extract-text-webpack-plugin to <2.0.0 as a peer dependency - updating documentation
Reviewed 5 of 5 files at r2. examples/basic/package.json, line 55 [r2] (raw file):
we can change this to ^1.0.0 examples/css-modules/package.json, line 65 [r2] (raw file):
1.0.0 Comments from Reviewable |
Reviewed 2 of 2 files at r3. Comments from Reviewable |
- Added supported versions of ExtractText plugin as a peerDependency - update the main documentation (./README.md) - update the basic example to use the latest supported version - extract-text-webpack-plugin to <2.0.0 as a peer dependency - updating documentation - updated font awesome loader
- Added supported versions of ExtractText plugin as a peerDependency - update the main documentation (./README.md) - update the basic example to use the latest supported version - extract-text-webpack-plugin to <2.0.0 as a peer dependency - updating documentation - updated font awesome loader
bootstrap-loader
breaks whenextract-text-webpack-plugin
2.0.0-beta.0
or higher is used. By addingextract-text-webpack-plugin
as a peer dependency with the supported version we can warn to user about this.This change is