Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extract text plugin as a peer dependency #109

Merged

Conversation

vpanjganj
Copy link
Contributor

@vpanjganj vpanjganj commented Jul 25, 2016

bootstrap-loader breaks when extract-text-webpack-plugin 2.0.0-beta.0 or higher is used. By adding extract-text-webpack-plugin as a peer dependency with the supported version we can warn to user about this.

screen shot 2016-07-25 at 11 27 29


This change is Reviewable

Vahid Panjganj added 2 commits July 25, 2016 10:51
- set extract-text-webpack-plugin as a peerDependencies on version
1.0.1 or lower
- update the main documentation (./README.md)
- update the basic example to use the latest supported version
- stop git from tracking webstorm text editor settings
@vpanjganj vpanjganj changed the title Restricted extract text peer dependency Adding extract text plugin as a peer dependency Jul 25, 2016
@justin808
Copy link
Member

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.


.gitignore, line 5 [r1] (raw file):

*.log
.DS_Store
**/.idea/

remove


package.json, line 38 [r1] (raw file):

  "peerDependencies": {
    "css-loader": "*",
    "extract-text-webpack-plugin": "<=1.0.1",

Not sure if you want to be so precise. What if 1.0.2 is released?

How about "< 2" (not sure a single digit works).

     '0.9.1': '2015-11-04T22:59:32.183Z',
     '1.0.0': '2016-01-03T22:08:29.766Z',
     '1.0.1': '2016-01-06T18:27:40.799Z',
     '2.0.0-beta.0': '2016-07-13T07:28:59.647Z',
     '2.0.0-beta.1': '2016-07-13T12:04:23.150Z',

README.md, line 157 [r1] (raw file):

Default: `false`

Extract styles to stand-alone css file using `extract-text-webpack-plugin` version `1.0.1` or lower. See [extract-text-plugin](https://github.com/webpack/extract-text-webpack-plugin) for more details.

see comment regarding the peer specification


examples/basic/package.json, line 53 [r1] (raw file):

    "eslint": "^1.9.0",
    "eslint-config-airbnb": "^1.0.0",
    "extract-text-webpack-plugin": "~1.0.1",

not sure on the ~ node specification.


Comments from Reviewable

- removing .idea from gitignore
- extract-text-webpack-plugin to <2.0.0 as a peer dependency
- updating documentation
@justin808
Copy link
Member

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 6 unresolved discussions.


examples/basic/package.json, line 55 [r2] (raw file):

    "extract-text-webpack-plugin": "^1.0.1",
    "file-loader": "^0.8.4",
    "font-awesome-loader": "^0.0.1",

we can change this to ^1.0.0


examples/css-modules/package.json, line 65 [r2] (raw file):

    "extract-text-webpack-plugin": "^0.9.1",
    "file-loader": "^0.8.4",
    "font-awesome-loader": "^0.0.1",

1.0.0


Comments from Reviewable

@justin808
Copy link
Member

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 6 unresolved discussions.


Comments from Reviewable

@justin808 justin808 merged commit 5c51234 into shakacode:master Jul 27, 2016
justin808 pushed a commit that referenced this pull request Aug 4, 2016
- Added supported versions of ExtractText plugin as a peerDependency
- update the main documentation (./README.md)
- update the basic example to use the latest supported version
- extract-text-webpack-plugin to <2.0.0 as a peer dependency
- updating documentation
- updated font awesome loader
justin808 pushed a commit that referenced this pull request Aug 31, 2016
- Added supported versions of ExtractText plugin as a peerDependency
- update the main documentation (./README.md)
- update the basic example to use the latest supported version
- extract-text-webpack-plugin to <2.0.0 as a peer dependency
- updating documentation
- updated font awesome loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants