Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix change timestampOffset on discontinuities when not necessary #7823

Merged
merged 3 commits into from
Jan 3, 2025
Merged

fix: Fix change timestampOffset on discontinuities when not necessary #7823

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7598824
test: Fix GAP in Safari test
avelad Jan 2, 2025
16b2aa9
Another fix :)
avelad Jan 2, 2025
4a7f88a
Fix lint
avelad Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/media/media_source_engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1599,6 +1599,13 @@ shaka.media.MediaSourceEngine = class {
return;
}

// Avoid changing timestampOffset when the difference is less than 100 ms
// from the end of the current buffer.
const bufferEnd = this.bufferEnd(contentType);
if (bufferEnd && Math.abs(bufferEnd - timestampOffset) < 0.1) {
return;
}

// Queue an abort() to help MSE splice together overlapping segments.
// We set appendWindowEnd when we change periods in DASH content, and the
// period transition may result in overlap.
Expand Down
Loading