fix(Widevine): Add default audio/video robustness for Widevine #7808
Conversation
The following bug is avoided in Chromium: `It is recommended that a robustness level be specified. Not specifying the robustness level could result in unexpected behavior.Understand this warningAI` It also prevents errors when initializing EME on Android.
avelad
added
type: bug
avelad
requested review from
littlespex,
joeyparrish,
JulianDomingo,
theodab and
tykus160
|
Incremental code coverage: 100.00% |
| @@ -427,6 +427,14 @@ shaka.drm.DrmEngine = class { | |||
| (this.config_.advanced && | |||
| this.config_.advanced[drmInfo.keySystem] && | |||
| this.config_.advanced[drmInfo.keySystem][robustnessType]) || ''; | |||
| if (items == '' && | |||
There was a problem hiding this comment.
I guess it's out of scope for this PR, but I probably should have asked for this expandRobustness function to have JSDoc for the parameters and return type...
|
This doesn't cherry-pick cleanly to v4.12.x, and after spending some time on merge conflicts, I have decided to give up. If you'd like to cherry-pick it to the release branches, please fix the merge conflicts manually and/or reimplement on the v4.12.x branch. Thanks!
I have long disagreed with this warning in Chromium. I think it's misleading and unhelpful, and I have argued against it since it was first introduced. |
The following bug is avoided in Chromium:
It is recommended that a robustness level be specified. Not specifying the robustness level could result in unexpected behavior.It also prevents errors when initializing EME on Android.
Fixes #7760