Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS interstitials only first item referenced in the X-ASSET-LIST is played #7661

Closed
hardim11 opened this issue Nov 25, 2024 · 0 comments · Fixed by #7662
Closed

HLS interstitials only first item referenced in the X-ASSET-LIST is played #7661

hardim11 opened this issue Nov 25, 2024 · 0 comments · Fixed by #7662
Assignees
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@hardim11
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Not DRM related

What version of Shaka Player are you using?

v4.12.2 - via the Demo page

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
demo app link

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Win11 / Chrome 131

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
n/a

What are the manifest and license server URIs?

main manifest URL https://d246vxj7zy7k76.cloudfront.net/bbb/main_is.m3u8
Asset list file https://d246vxj7zy7k76.cloudfront.net/adlists/list_midroll.json

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

default

What did you do?

Created a main content package using Shaka packager, edited to add Date Range Interstitials which referenced a JSON on the same cloudfront distribution

What did you expect to happen?
For the lists which have more than 1 item in them, all items should play in order

What actually happened?

Only the first item in the list plays, if I change the order of items in the list, then it's still the first item in the list which plays

Are you planning send a PR to fix it?
sorry I don't have sufficient knowledge to do

@hardim11 hardim11 added the type: bug Something isn't working correctly label Nov 25, 2024
@avelad avelad added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 25, 2024
@avelad avelad added this to the v4.13 milestone Nov 25, 2024
@avelad avelad self-assigned this Nov 25, 2024
@avelad avelad closed this as completed in 79b1536 Nov 26, 2024
avelad added a commit that referenced this issue Nov 27, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 25, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants