Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time ID3, emsg, and metadata events to the presentation timeline #7556

Open
joeyparrish opened this issue Nov 6, 2024 · 1 comment
Open

Time ID3, emsg, and metadata events to the presentation timeline #7556

joeyparrish opened this issue Nov 6, 2024 · 1 comment
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
Milestone
Backlog

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
No

Is your feature request related to a problem? Please describe.

ID3, emsg, and metadata events are fired as soon as the metadata is parsed. This can confuse ad SDKs and others interfacing to them.

Describe the solution you'd like

These events should be fired when we reach appropriate times in the presentation.

This could leverage TimelineRegion so that metadata events with a range of applicable times fire appropriately even when seeking.

Describe alternatives you've considered

Making everyone else cope with it so I can be lazy

Additional context

Internal discussion within Google at b/365662199

Are you planning send a PR to add it?
Yes, though the work hasn't been scheduled yet
@joeyparrish joeyparrish added the type: enhancement New feature or request label Nov 6, 2024
@shaka-bot shaka-bot added this to the Backlog milestone Nov 6, 2024
@avelad avelad added the priority: P3 Useful but not urgent label Nov 7, 2024
@joeyparrish
Copy link
Member Author

Received this raw AAC ID3 stream from Alvaro for testing: https://cadena100-cope.flumotion.com/chunks.m3u8

@avelad avelad mentioned this issue Nov 8, 2024
Merged
avelad added a commit that referenced this issue Nov 12, 2024
@avelad
perf: Improve performance when parsing EMSG (#7557)
cb66f47 
With the change, we reuse MediaSource's MP4 parsing code to avoid
parsing everything twice.
It will also help with the implementation of
#7556 in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@joeyparrish @avelad @shaka-bot