fix(MSS): Fix playback of some MSS streams #7517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
added
the
component: MSS
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
|
Incremental code coverage: 100.00% |
joeyparrish
approved these changes
Oct 28, 2024
ncocaign
added a commit
to ncocaign/shaka-player
that referenced
this pull request
Oct 29, 2024
fix(DASH): Fix playback of some DASH with multiple period (shaka-project#7516) With this change, closeSegmentIndex() of stream removed of a period are defered in StreamingEngine.onUpdate_() Fixes shaka-project#7517
ncocaign
added a commit
to ncocaign/shaka-player
that referenced
this pull request
Oct 29, 2024
…ect#7517) With this change, closeSegmentIndex() of all streams of a removed period are defered in StreamingEngine.onUpdate_() Fixes shaka-project#7517
avelad
added a commit
that referenced
this pull request
Nov 12, 2024
With this change, no default flags are used. It seems that when a sample has to use the default flags, in Safari, it can cause problems with MSS. With HLS this does not happen. Fixes #7509
avelad
added a commit
that referenced
this pull request
Nov 12, 2024
With this change, no default flags are used. It seems that when a sample has to use the default flags, in Safari, it can cause problems with MSS. With HLS this does not happen. Fixes #7509
joeyparrish
pushed a commit
that referenced
this pull request
Nov 12, 2024
With this change, no default flags are used. It seems that when a sample has to use the default flags, in Safari, it can cause problems with MSS. With HLS this does not happen. Fixes #7509
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, no default flags are used. It seems that when a sample has to use the default flags, in Safari, it can cause problems with MSS. With HLS this does not happen.
Fixes #7509