Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background colors broken in CSS generated by Less v3 #4027

Closed
joeyparrish opened this issue Mar 15, 2022 · 1 comment · Fixed by #4028
Closed

Background colors broken in CSS generated by Less v3 #4027

joeyparrish opened this issue Mar 15, 2022 · 1 comment · Fixed by #4028
Assignees
@joeyparrish
Labels
component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.3

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
yes

What version of Shaka Player are you using?
main

Can you reproduce the issue with our latest release version?
no

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
demo

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
ChromeOS stable 98

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

N/A; anything in the demo

What configuration are you using? What is the output of player.getConfiguration()?

default

What did you do?

Open content in the latest nightly build

What did you expect to happen?
Close button should have a white background

What actually happened?

Close button has no background, CSS debugger shows that the background attribute is invalid: rgba(255 255 3%).
@joeyparrish joeyparrish added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release labels Mar 15, 2022
@joeyparrish joeyparrish self-assigned this Mar 15, 2022
@joeyparrish
Copy link
Member Author

In #3991, I changed the syntax of our colors to a modern rgba syntax. For example, rgba(255, 255, 255, 0.85) would become rgba(255 255 255 / 85%). However, less v3 seems not to understand that properly, and performs division on the last two parts, resulting in output of rgba(255 255 3%), which is indeed invalid.

This doesn't affect any release branches, since #3991 hasn't been cherry-picked.

@github-actions github-actions bot added this to the v3.3 milestone Mar 15, 2022
@joeyparrish joeyparrish mentioned this issue Mar 15, 2022
Merged
joeyparrish added a commit that referenced this issue Mar 15, 2022
@joeyparrish
chore(deps): Upgrade less to v4 (prerelease) (#4028)
f5f5177 
In #3991, I changed the syntax of our colors to a modern rgba syntax.
For example, rgba(255, 255, 255, 0.85) would become rgba(255 255 255 /
85%). However, less v3 seems not to understand that properly, and
performs division on the last two parts, resulting in output of
rgba(255 255 3%), which is indeed invalid.

This fixes the issue by upgrading to less v4, which understands the
new rgba syntax and leaves it alone. The output for that will now
match the input.

To work around an issue with less v4, this uses a prerelease version
with a fix for less/less.js#3693 . See also
tomas/needle#391

This doesn't affect any release branches, since #3991 hasn't been
cherry-picked.

Closes #4027
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label May 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.3
Development

Successfully merging a pull request may close this issue.

chore(deps): Upgrade less to v4 (prerelease)
1 participant
@joeyparrish