Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less compilation failing on macOS #3981

Closed
joeyparrish opened this issue Feb 19, 2022 · 3 comments · Fixed by #3982
Closed

Less compilation failing on macOS #3981

joeyparrish opened this issue Feb 19, 2022 · 3 comments · Fixed by #3982
Assignees
@joeyparrish
Labels
component: build system The issue involves the build system of Shaka Player status: archived Archived and locked; will not be updated type: CI An issue with our continuous integration tests
Milestone
v4.0

Comments

@joeyparrish
Copy link
Member

In GitHub Actions and on the mac in our lab, less fails to fetch web fonts such as https://fonts.googleapis.com/css?family=Roboto, failing with ECONNRESET.

Furthermore, the logs show Externs generation failed, which is due to a copy-paste bug in our build scripts.

It's unclear why this is happening, or why it's only on mac. In our lab, we're running nodejs v17.5.0 and less v4.1.2.
@joeyparrish joeyparrish added type: CI An issue with our continuous integration tests component: build system The issue involves the build system of Shaka Player labels Feb 19, 2022
@joeyparrish joeyparrish self-assigned this Feb 19, 2022
@joeyparrish
Copy link
Member Author

It looks like this started with the upgrade from less v3 to less v4.

@joeyparrish
Copy link
Member Author

Filed less/less.js#3693 to see if this can be addressed upstream before I take any hasty action here. It would be ideal to be able to upgrade.

@joeyparrish joeyparrish mentioned this issue Feb 19, 2022
Closed
@github-actions github-actions bot added this to the Backlog milestone Feb 19, 2022
@joeyparrish
Copy link
Member Author

Found a relatively painless downgrade path after all. Still hoping for a fix upstream and then an upgrade to v4 later.

@joeyparrish joeyparrish mentioned this issue Feb 19, 2022
Merged
joeyparrish added a commit that referenced this issue Feb 22, 2022
@joeyparrish
build: Downgrade less (#3982)
a67cb6e 
Downgrade less to v3.  v4 is failing on macOS for some reason.  See
less/less.js#3693

This also makes some less/CSS changes that are useful for future
upgrades:

 - wrap all calculations in calc(), which is required in less v4
 - remove unneeded @transparent variable

Finally, this fixes an erroneous error message that said "extern
generation failed" instead of "CSS compilation failed".

Closes #3981
joeyparrish added a commit to joeyparrish/less.js that referenced this issue Mar 15, 2022
@joeyparrish
fix: Use pre-release fix for needle
aef9a5c 
See also:
 - shaka-project/shaka-player#3981
 - less#3693
 - tomas/needle#392
 - nodejs/node#27916
joeyparrish added a commit to joeyparrish/less.js that referenced this issue Mar 15, 2022
@joeyparrish
fix: Use pre-release fix for needle
e7ac948 
See also:
 - shaka-project/shaka-player#3981
 - less#3693
 - tomas/needle#392
 - nodejs/node#27916
joeyparrish added a commit to joeyparrish/less.js that referenced this issue Mar 15, 2022
@joeyparrish
fix: Use pre-release fix for needle
4fb5384 
See also:
 - shaka-project/shaka-player#3981
 - less#3693
 - tomas/needle#392
 - nodejs/node#27916
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Apr 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2022
@avelad avelad modified the milestones: Backlog, v4.0 May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
component: build system The issue involves the build system of Shaka Player status: archived Archived and locked; will not be updated type: CI An issue with our continuous integration tests
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

build: Downgrade less
2 participants
@joeyparrish @avelad