Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMCD breaks offline downloads #3712

Closed
avelad opened this issue Oct 21, 2021 · 0 comments · Fixed by #3716
Closed

CMCD breaks offline downloads #3712

avelad opened this issue Oct 21, 2021 · 0 comments · Fixed by #3716
Labels
component: offline The issue involves the offline storage system of Shaka Player priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.3

Comments

@avelad
Copy link
Member

avelad commented Oct 21, 2021

Have you read the FAQ and checked for duplicate open issues? Yes

What version of Shaka Player are you using? Nightly

Can you reproduce the issue with our latest release version? N/A

Can you reproduce the issue with the latest code from master? Yes

Are you using the demo app or your own custom app? Demo APP

If custom app, can you reproduce the issue using our demo app? Demo APP

What browser and OS are you using?
Chrome 95, macOS 11

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

enable CMCD
download a asset
play a asset

What did you expect to happen?
The download works

What actually happened?

The download doesn't work

Video:

cmcd.mov
@avelad avelad added the type: bug Something isn't working correctly label Oct 21, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Oct 21, 2021
@TheModMaker TheModMaker added component: offline The issue involves the offline storage system of Shaka Player priority: P1 Big impact or workaround impractical; resolve before feature release labels Oct 21, 2021
@avelad avelad mentioned this issue Oct 26, 2021
Merged
theodab pushed a commit that referenced this issue Oct 26, 2021
fix(offline): Do not apply CMCD query args to offline URIs (#3716)
173ae42 
Closes #3712
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 25, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: offline The issue involves the offline storage system of Shaka Player priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.3
Development

Successfully merging a pull request may close this issue.

Fix playback of offline downloads with CMCD enabled avelad/shaka-player
3 participants
@TheModMaker @avelad @shaka-bot