Period flattening error on DASH manifests with image AdaptationSet #3383
Comments
|
After this PR #3365, the tileLayout information will be entered into the segments, so in theory DASH could be adapted to use the same format and eliminate this limitation. |
|
I think the short-term solution needs to be a fix to period-flattening to ignore images. That could be cherry-picked to the existing v3.0.x and v3.1.x release branches and can appear in a bugfix release, whereas any pending feature PRs are going to first appear in a future feature release. |
joeyparrish
added
type: bug
|
@jennyzhua Can you copy the manifest here (text) so I can work on the fix? |
|
@jennyzhua, we have the content URL you shared privately, and I am working on this issue now. The issue seems to be particular to having two different resolutions of images per period. You may be able to work around it by removing one on the backend or at runtime by manipulating the manifest in the client. I hope to have a solution soon, though. Thanks for your patience! |
|
I have a fix working now in manual testing, and regression tests to cover this case as well. The changes are in review now, and will be in our next release. |
|
@joeyparrish After closing this issue, will you release the version 3.2? What day? |
Matching image streams across periods was not working correctly with multiple streams per period. Matching was done on MIME type only, meaning there was no way to differentiate multiple streams. Resolution is a better signal, so this uses the same logic as for video resolution in thumbnail resolution matching. This also adds extra error logs that helped track down the issue, and fixes some comment typos. Issue #3383 Change-Id: I067de59c222a165d58926646f53fa61862853377
We filter out duplicate streams for all other types, so we should do this for images, as well. This also updates all PeriodCombiner test cases to include the imageStreams property. Issue #3383 Change-Id: I63355f85d4e12bd25c1cadce29a040d17c4e7d61
When loading offline content, we should load the image streams as well. Issue #3383 Change-Id: I8cdd3d1ade188b7b2278a0eac5510a968229c6fc
|
I'm working on cherry-picks for the releases now. v3.2.0 and v3.1.2 at least, and v3.0.13 and v2.5.24 if necessary. |
Matching image streams across periods was not working correctly with multiple streams per period. Matching was done on MIME type only, meaning there was no way to differentiate multiple streams. Resolution is a better signal, so this uses the same logic as for video resolution in thumbnail resolution matching. This also adds extra error logs that helped track down the issue, and fixes some comment typos. Issue #3383 Change-Id: I067de59c222a165d58926646f53fa61862853377
We filter out duplicate streams for all other types, so we should do this for images, as well. This also updates all PeriodCombiner test cases to include the imageStreams property. Issue #3383 Change-Id: I63355f85d4e12bd25c1cadce29a040d17c4e7d61
When loading offline content, we should load the image streams as well. Issue #3383 Change-Id: I8cdd3d1ade188b7b2278a0eac5510a968229c6fc
When playing multiperiod content, we should not require thumbnails to be present in every period. This fixes this case and adds a regression test. Closes #3383 Change-Id: I4403a1b8670cffcc46de32470e2d830dc199c9f4
Have you read the FAQ and checked for duplicate open issues?
yes
What link can we use to reproduce this?
manifest sent in email
What version of Shaka Player are you using?
v3.1.0-uncompiled
What browser and OS are you using?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.128 Safari/537.36
What did you do?
Play the manifest in the demo app
What did you expect to happen?
Playback starts successfully
What actually happened?
Encountered Shaka Error MANIFEST.PERIOD_FLATTENING_FAILED ()
The text was updated successfully, but these errors were encountered: