Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CastUtils TimeRanges test sometimes times out #1215

Closed
theodab opened this issue Jan 5, 2018 · 2 comments
Closed

CastUtils TimeRanges test sometimes times out #1215

theodab opened this issue Jan 5, 2018 · 2 comments
Labels
priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated status: unable to reproduce Issue could not be reproduced by the team type: code health A code health issue type: enhancement New feature or request

Comments

@theodab
Copy link
Contributor

theodab commented Jan 5, 2018

CastUtils TimeRanges deserialize into equivalent objects sometimes times out when I run the full test suite. I've seen this happen a lot while testing other things, but annoyingly I am having a very hard time reproducing it on purpose. I ran the CastUtils tests 10k times in a row and eventually it was reproduced; notably, once it started happening (~5k runs in) it suddenly started happening multiple times in a row, which suggests it involves some kind of external state.
That particular test does not have any asynchronous parts, but the beforeEach and afterEach attached to it do. In particular, the beforeEach involves loading file assets and appending a buffer to media source engine, so it might be some file I/O problem.

@theodab theodab added the type: code health A code health issue label Jan 5, 2018
@theodab theodab added this to the Backlog milestone Jan 5, 2018
@TheModMaker TheModMaker added the type: enhancement New feature or request label Mar 5, 2018
@joeyparrish joeyparrish modified the milestones: Backlog, v2.6 Mar 13, 2018
@theodab theodab added the flake label Mar 27, 2018
shaka-bot pushed a commit that referenced this issue Mar 28, 2018
This test has been flakey on OSX for quite a while, but it was very
occasional, and the likely cause of the flake is unrelated to the test
itself, so it was never really dealt with.
Recently, though, the test has been failing repeatedly on the BuildBot.
This change quarantines the test so that the BuildBot will stop failing.

Issue #1215

Change-Id: I1a721976c277cfb9324b0b3f9cf8eae49b17d1ca
@vaage vaage modified the milestone: v2.6 Nov 26, 2018
@joeyparrish joeyparrish modified the milestones: v2.6, Backlog Feb 12, 2020
@joeyparrish joeyparrish removed the flake label Sep 27, 2021
@theodab theodab added the priority: P4 Nice to have / wishful thinking label Oct 2, 2021
@avelad
Copy link
Member

avelad commented May 19, 2022

@joeyparrish I'm not sure we add it, since we want to do #4214 in the future

@joeyparrish
Copy link
Member

Agreed. Also this hasn't been an issue in recent momentary.

@joeyparrish joeyparrish added the status: will not implement The team chooses not to implement this enhancement label May 23, 2022
@joeyparrish joeyparrish removed this from the Backlog milestone May 23, 2022
@joeyparrish joeyparrish added status: unable to reproduce Issue could not be reproduced by the team and removed status: will not implement The team chooses not to implement this enhancement labels May 23, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated status: unable to reproduce Issue could not be reproduced by the team type: code health A code health issue type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants