Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CastReceiver integration tests #1162

Closed
joeyparrish opened this issue Nov 29, 2017 · 3 comments
Closed

CastReceiver integration tests #1162

joeyparrish opened this issue Nov 29, 2017 · 3 comments
Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue platform: Cast Issues affecting Cast devices priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated status: will not implement The team chooses not to implement this enhancement type: code health A code health issue type: enhancement New feature or request

Comments

@joeyparrish
Copy link
Member

We currently have unit tests on shaka.cast.CastReceiver, but no integration tests. We should write integration tests that integrate CastReceiver with Player. This could help catch bugs like #1128 (uncaught receiver-side exceptions) sooner by simulating the environment of a receiver app.

These tests could be run on a single device, which means better automation than we could get from actually casting from one device to another.
@joeyparrish joeyparrish added type: code health A code health issue type: enhancement New feature or request flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue labels Nov 29, 2017
@joeyparrish joeyparrish added this to the v2.4.0 milestone Nov 29, 2017
@theodab theodab self-assigned this Nov 29, 2017
@joeyparrish joeyparrish modified the milestones: v2.4.0, Backlog Dec 4, 2017
shaka-bot pushed a commit that referenced this issue Dec 6, 2017
@theodab
Added an integration test for cast receiver
5f612bd 
This adds a single integration test for cast receiver, as well as a
framework for adding more in the future.
This particular test pauses at each stage in Player.load where the
player could theoretically be polled to compose an update message, and
waits for an update message to be polled. This should help catch any
further null exceptions in the cast receiver that prevent update
messages from being sent out.

Issue #1162

Change-Id: If24486dd821275ab674960e559bd6d10776955a7
joeyparrish pushed a commit that referenced this issue Dec 8, 2017
@theodab @joeyparrish
Added an integration test for cast receiver
80ece28 
This adds a single integration test for cast receiver, as well as a
framework for adding more in the future.
This particular test pauses at each stage in Player.load where the
player could theoretically be polled to compose an update message, and
waits for an update message to be polled. This should help catch any
further null exceptions in the cast receiver that prevent update
messages from being sent out.

Issue #1162

Change-Id: If24486dd821275ab674960e559bd6d10776955a7
@joeyparrish
Copy link
Member Author

We now have one integration test for CastReceiver, in which we delay various stages of load() to make sure the sender continues to get updates. This helped catch and solve some runtime exceptions.

We will leave this open until we write some general integration tests for CastReceiver, unrelated to any known bug, along the lines of the playback tests we have in player_integration.js. At that point, we will have reasonable general coverage, and can close this issue. Regression tests can be added to cast_receiver_integration.js for future bugs.

@joeyparrish joeyparrish modified the milestones: v2.4, v2.5 Mar 4, 2018
@joeyparrish joeyparrish modified the milestones: v2.5, v2.6 Mar 14, 2018
@joeyparrish joeyparrish modified the milestones: v2.6, Backlog Sep 16, 2019
@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@theodab theodab added the priority: P4 Nice to have / wishful thinking label Sep 29, 2021
@theodab theodab removed their assignment Sep 29, 2021
@avelad avelad added the platform: Cast Issues affecting Cast devices label May 3, 2022
@avelad
Copy link
Member

avelad commented May 19, 2022

@joeyparrish I'm not sure we add it, since we want to do #4214 in the future

@joeyparrish
Copy link
Member Author

Agreed. Thanks!

@joeyparrish joeyparrish added the status: will not implement The team chooses not to implement this enhancement label May 23, 2022
@joeyparrish joeyparrish removed this from the Backlog milestone May 23, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue platform: Cast Issues affecting Cast devices priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated status: will not implement The team chooses not to implement this enhancement type: code health A code health issue type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joeyparrish @avelad @theodab