Skip to content

Commit

Permalink
test: Enable disabled test for Chromecast (#7820)
Browse files Browse the repository at this point in the history
  • Loading branch information
avelad authored and joeyparrish committed Jan 6, 2025
1 parent 6ced74a commit f77850c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion lib/polyfill/media_capabilities.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ shaka.polyfill.MediaCapabilities = class {
let displayType = videoConfig.contentType;
if (videoConfig.width && videoConfig.height) {
// All Chromecast can support 720p videos
if (videoConfig.width > 1280 || videoConfig.height > 720) {
if (videoConfig.width > 1280 && videoConfig.height > 720) {
displayType +=
`; width=${videoConfig.width}; height=${videoConfig.height}`;
}
Expand Down
7 changes: 0 additions & 7 deletions test/transmuxer/transmuxer_integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -353,13 +353,6 @@ describe('Transmuxer Player', () => {
/* width= */ 720, /* height= */ 1280)) {
pending('Codec H.265 is not supported by the platform.');
}
if (shaka.util.Platform.isChromecast()) {
// FIXME: Test disabled on Chromecast. Now that our test environment
// can do full support checks on Chromecast, including resolution, this
// 720x1280 vertical video is over the limit for a 1080p screen. This
// fails on any Chromecast with H.265 support.
pending('Disabled on Chromecast.');
}

// eslint-disable-next-line max-len
await player.load('/base/test/test/assets/hls-ts-muxed-aac-h265/media.m3u8');
Expand Down

0 comments on commit f77850c

Please sign in to comment.