fix(UI): Allow pause non-linear video ads (#7699)

shaka-project · Dec 4, 2024 · 8633980 · 8633980
1 parent cc7c738
commit 8633980
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/ui/controls.js b/ui/controls.js
@@ -1614,11 +1614,13 @@ shaka.ui.Controls = class extends shaka.util.FakeEventTarget {
 
   /** @private */
   onPlayPauseClick_() {
-    if (this.ad_ && this.ad_.isLinear()) {
+    if (this.ad_) {
       this.playPauseAd();
-    } else {
-      this.playPausePresentation();
+      if (this.ad_.isLinear()) {
+        return;
+      }
     }
+    this.playPausePresentation();
   }
 
   /** @private */

diff --git a/ui/play_button.js b/ui/play_button.js
@@ -77,11 +77,13 @@ shaka.ui.PlayButton = class extends shaka.ui.Element {
     });
 
     this.eventManager.listen(this.button, 'click', () => {
-      if (this.ad && this.ad.isLinear()) {
+      if (this.ad) {
         this.controls.playPauseAd();
-      } else {
-        this.controls.playPausePresentation();
+        if (this.ad.isLinear()) {
+          return;
+        }
       }
+      this.controls.playPausePresentation();
     });
 
     if (this.ad) {