fix(Subtitles): Prevent rounding errors when filtering duplicated cues (

#8018) Related to #6773
shaka-project · Feb 5, 2025 · 24283e6 · 24283e6
1 parent ece88d6
commit 24283e6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/text/cue.js b/lib/text/cue.js
@@ -371,8 +371,12 @@ shaka.text.Cue = class {
     // performance optimization.  We can avoid the more expensive recursive
     // checks if the top-level properties don't match.
     // See: https://github.com/shaka-project/shaka-player/issues/3018
-    if (cue1.startTime != cue2.startTime || cue1.endTime != cue2.endTime ||
-      cue1.payload != cue2.payload) {
+    if (cue1.payload != cue2.payload) {
+      return false;
+    }
+    const isDiffNegligible = (a, b) => Math.abs(a - b) < 0.001;
+    if (!isDiffNegligible(cue1.startTime, cue2.startTime) ||
+        !isDiffNegligible(cue1.endTime, cue2.endTime)) {
       return false;
     }
     for (const k in cue1) {