Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✔ Geosite group validation + PAC regeneration on version update #2988

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

database64128
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

  • Require translation update

  • Require document update (readme.md, wikipage, etc)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

  • Validate geosite group configuration
  • Reset to default if specified group doesn't exist
  • Regenerate pac.txt on version update (can be turned off)
  • Cleanup of Configuration to separate loading logic and processing logic

- Validate geosite group configuration
- Reset to default if specified group doesn't exist
- Regenerate pac.txt on version update (can be turned off)
- Cleanup of `Configuration` to separate loading logic and processing logic
@chenshaoju
Copy link
Collaborator

There is an tiny odd issue in Shadowsocks-4.2.0.40-Release.exe, when I override update from 4.2.1.0, The Edit Servers window shows up when Shadowsocks startup.

After re-open Shadowsocks 2 times, the Edit servers window does not show up in startup again. 🤔

Copy link
Collaborator

@chenshaoju chenshaoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me, but someone else must approve.

@database64128
Copy link
Contributor Author

There is an tiny odd issue in Shadowsocks-4.2.0.40-Release.exe, when I override update from 4.2.1.0, The Edit Servers window shows up when Shadowsocks startup.

After re-open Shadowsocks 2 times, the Edit servers window does not show up in startup again. 🤔

That's because I changed the variable name from isDefault to firstRun for clarification. The old value is not migrated to the new one. So the program thinks it's the first run. 😅

@database64128 database64128 merged commit d72c2b0 into master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants