Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔙 Backport 2c15276 from v5/master to master #2910

Merged
merged 2 commits into from
Jun 27, 2020
Merged

🔙 Backport 2c15276 from v5/master to master #2910

merged 2 commits into from
Jun 27, 2020

Conversation

database64128
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

  • Require translation update

  • Require document update (readme.md, wikipage, etc)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

  • Compared to 2c15276: changed socketsHttpHandler to HttpClientHandler due to legacy .NET Framework
  • Use System.Net.Http.HttpClient for GeositeUpdater
  • New update check mechanism: first download checksum and compare, only download GeoSite DB on different checksum
  • Verifiy downloaded GeoSite DB by comparing sha256sum before committing the change

- Compared to 2c15276: changed socketsHttpHandler to HttpClientHandler due to legacy .NET Framework
- Use System.Net.Http.HttpClient for GeositeUpdater
- New update check mechanism: first download checksum and compare, only download GeoSite DB on different checksum
- Verifiy downloaded GeoSite DB by comparing sha256sum before committing the change
@celeron533 celeron533 merged commit 2030163 into shadowsocks:master Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants