Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use v2ray geosite to replace gfwlist #2875

Merged
merged 10 commits into from May 16, 2020
Merged

use v2ray geosite to replace gfwlist #2875

merged 10 commits into from May 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

  • Require translation update

  • Require document update (readme.md, wikipage, etc)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

Replace GFWList with v2ray GeoSite database in case GFWList finally stopped maintenance (gfwlist/gfwlist#1945).

TODO:

  • shared Github release API (Needn't, they has a release branch)
  • i18n update
  • customizable GeoSite group
  • more stability test
  • how to migrate?
  • give more time to GFWList
  • document update
  • announce breaking change

@ghost ghost marked this pull request as ready for review May 10, 2020 03:21
@ghost

This comment has been minimized.

@ghost ghost requested review from celeron533, chenshaoju and Stzx May 10, 2020 13:57
Copy link
Collaborator

@chenshaoju chenshaoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quick test is passed, Base appveyor Shadowsocks-4.1.10.36-Release.exe version.
👍 Looks good to me, but someone else must approve.

@celeron533 celeron533 merged commit c745c00 into shadowsocks:master May 16, 2020
@celeron533
Copy link
Contributor

@studentmain you can merge PRs if you are confident to do.

@chenshaoju chenshaoju mentioned this pull request Jun 10, 2020
@ghost ghost deleted the v2ray-geosite branch July 25, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants